From: "Simon Marchi (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>
To: Andrew Burgess <andrew.burgess@embecosm.com>, gdb-patches@sourceware.org
Cc: Christian Biesinger <cbiesinger@google.com>
Subject: [review] gdb: Ensure that !(a < a) is true in sort_cmp on obj_section objects
Date: Mon, 21 Oct 2019 17:34:00 -0000 [thread overview]
Message-ID: <20191021173440.DC0C221926@gnutoolchain-gerrit.osci.io> (raw)
In-Reply-To: <gerrit.1571672966000.I4b1e3e1640865104c0896cbb6c3fdbbc04d9645b@gnutoolchain-gerrit.osci.io>
Simon Marchi has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/177
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/177/1/gdb/objfiles.c
File gdb/objfiles.c:
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/177/1/gdb/objfiles.c@1055
PS1, Line 1055: does check that '!(a < a)'
Not sure if it's worth mentioning it, but to be exact, std::sort check when compiling with libstdc++'s debug mode.
next prev parent reply other threads:[~2019-10-21 17:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-21 15:49 Andrew Burgess (Code Review)
2019-10-21 16:02 ` Christian Biesinger (Code Review)
2019-10-21 17:34 ` Simon Marchi (Code Review) [this message]
2019-10-21 20:12 ` [pushed] " Sourceware to Gerrit sync (Code Review)
2019-10-21 20:12 ` Sourceware to Gerrit sync (Code Review)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191021173440.DC0C221926@gnutoolchain-gerrit.osci.io \
--to=gerrit@gnutoolchain-gerrit.osci.io \
--cc=andrew.burgess@embecosm.com \
--cc=cbiesinger@google.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox