From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-159899-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 121629 invoked by alias); 21 Oct 2019 17:34:47 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 121612 invoked by uid 89); 21 Oct 2019 17:34:47 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.3.1 spammy=HContent-Transfer-Encoding:8bit
X-HELO: mx1.osci.io
Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 21 Oct 2019 17:34:46 +0000
Received: by mx1.osci.io (Postfix, from userid 994)	id 809CB204CA; Mon, 21 Oct 2019 13:34:44 -0400 (EDT)
Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [IPv6:2620:52:3:1:5054:ff:fe06:16ca])	by mx1.osci.io (Postfix) with ESMTP id 0F7C720172;	Mon, 21 Oct 2019 13:34:40 -0400 (EDT)
Received: from localhost (localhost [127.0.0.1])	by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id DC0C221926;	Mon, 21 Oct 2019 13:34:40 -0400 (EDT)
X-Gerrit-PatchSet: 1
Date: Mon, 21 Oct 2019 17:34:00 -0000
From: "Simon Marchi (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>
To: Andrew Burgess <andrew.burgess@embecosm.com>,	gdb-patches@sourceware.org
Cc: Christian Biesinger <cbiesinger@google.com>
Auto-Submitted: auto-generated
X-Gerrit-MessageType: comment
Subject: [review] gdb: Ensure that !(a < a) is true in sort_cmp on obj_section objects
X-Gerrit-Change-Id: I4b1e3e1640865104c0896cbb6c3fdbbc04d9645b
X-Gerrit-Change-Number: 177
X-Gerrit-ChangeURL: <https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/177>
X-Gerrit-Commit: 18702701d93c806a00fe7563b6cc647fc943959d
In-Reply-To: <gerrit.1571672966000.I4b1e3e1640865104c0896cbb6c3fdbbc04d9645b@gnutoolchain-gerrit.osci.io>
References: <gerrit.1571672966000.I4b1e3e1640865104c0896cbb6c3fdbbc04d9645b@gnutoolchain-gerrit.osci.io>
X-Gerrit-Comment-Date: Mon, 21 Oct 2019 13:34:40 -0400
Reply-To: simon.marchi@polymtl.ca, andrew.burgess@embecosm.com, cbiesinger@google.com, gdb-patches@sourceware.org
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
User-Agent: Gerrit/3.0.3
Content-Type: text/plain; charset=UTF-8
Message-Id: <20191021173440.DC0C221926@gnutoolchain-gerrit.osci.io>
X-SW-Source: 2019-10/txt/msg00731.txt.bz2

Simon Marchi has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/177
......................................................................


Patch Set 1: Code-Review+2

(1 comment)

https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/177/1/gdb/objfiles.c 
File gdb/objfiles.c:

https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/177/1/gdb/objfiles.c@1055 
PS1, Line 1055: does check that '!(a < a)'
Not sure if it's worth mentioning it, but to be exact, std::sort check when compiling with libstdc++'s debug mode.