From: "Tankut Baris Aktemur (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>
To: gdb-patches@sourceware.org
Cc: Tom de Vries <tdevries@suse.de>
Subject: [review] infcall: move assertions in 'call_function_by_hand_dummy' to an earli...
Date: Mon, 21 Oct 2019 07:36:00 -0000 [thread overview]
Message-ID: <20191021073616.7322421926@gnutoolchain-gerrit.osci.io> (raw)
In-Reply-To: <gerrit.1571406803000.I411ac083ac6a9ee6eb93c4b82393a81a4fc927be@gnutoolchain-gerrit.osci.io>
Tankut Baris Aktemur has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/139
......................................................................
Patch Set 1:
(1 comment)
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/139/1//COMMIT_MSG
Commit Message:
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/139/1//COMMIT_MSG@12
PS1, Line 12:
> Can you make it explicit here why this is a good idea?
How about this? "... so that (1) the checks are grouped together at the beginning of the function for improved readability, and (2) we don't have to align and push things on the stack only to find out later that the function call is illegal."
next prev parent reply other threads:[~2019-10-21 7:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-18 13:53 Tankut Baris Aktemur (Code Review)
2019-10-18 15:10 ` Tom de Vries (Code Review)
2019-10-21 7:36 ` Tankut Baris Aktemur (Code Review) [this message]
2019-10-21 18:55 ` Luis Machado (Code Review)
2019-10-21 19:00 ` Simon Marchi (Code Review)
2019-10-22 7:13 ` [review v2] " Tankut Baris Aktemur (Code Review)
2019-10-22 7:19 ` Tankut Baris Aktemur (Code Review)
2019-10-22 8:57 ` Tom de Vries (Code Review)
2019-10-22 16:27 ` Simon Marchi (Code Review)
2019-10-23 18:50 ` [pushed] " Sourceware to Gerrit sync (Code Review)
2019-10-23 18:50 ` Sourceware to Gerrit sync (Code Review)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191021073616.7322421926@gnutoolchain-gerrit.osci.io \
--to=gerrit@gnutoolchain-gerrit.osci.io \
--cc=gdb-patches@sourceware.org \
--cc=tankut.baris.aktemur@intel.com \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox