From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-159883-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 3736 invoked by alias); 21 Oct 2019 07:36:20 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 3728 invoked by uid 89); 21 Oct 2019 07:36:20 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.3.1 spammy=COMMIT_MSG, commit_msg, U*COMMIT_MSG, COMMIT_MSG@12
X-HELO: mx1.osci.io
Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 21 Oct 2019 07:36:19 +0000
Received: by mx1.osci.io (Postfix, from userid 994)	id 0383F2041E; Mon, 21 Oct 2019 03:36:17 -0400 (EDT)
Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [IPv6:2620:52:3:1:5054:ff:fe06:16ca])	by mx1.osci.io (Postfix) with ESMTP id B68D620183;	Mon, 21 Oct 2019 03:36:16 -0400 (EDT)
Received: from localhost (localhost [127.0.0.1])	by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id 7322421926;	Mon, 21 Oct 2019 03:36:16 -0400 (EDT)
X-Gerrit-PatchSet: 1
Date: Mon, 21 Oct 2019 07:36:00 -0000
From: "Tankut Baris Aktemur (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>
To: gdb-patches@sourceware.org
Cc: Tom de Vries <tdevries@suse.de>
Auto-Submitted: auto-generated
X-Gerrit-MessageType: comment
Subject: [review] infcall: move assertions in 'call_function_by_hand_dummy' to an earli...
X-Gerrit-Change-Id: I411ac083ac6a9ee6eb93c4b82393a81a4fc927be
X-Gerrit-Change-Number: 139
X-Gerrit-ChangeURL: <https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/139>
X-Gerrit-Commit: 36ec4e04bb56dca32d147449d58428143836ddc6
In-Reply-To: <gerrit.1571406803000.I411ac083ac6a9ee6eb93c4b82393a81a4fc927be@gnutoolchain-gerrit.osci.io>
References: <gerrit.1571406803000.I411ac083ac6a9ee6eb93c4b82393a81a4fc927be@gnutoolchain-gerrit.osci.io>
X-Gerrit-Comment-Date: Mon, 21 Oct 2019 03:36:16 -0400
Reply-To: tankut.baris.aktemur@intel.com, tdevries@suse.de, gdb-patches@sourceware.org
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
User-Agent: Gerrit/3.0.3
Content-Type: text/plain; charset=UTF-8
Message-Id: <20191021073616.7322421926@gnutoolchain-gerrit.osci.io>
X-SW-Source: 2019-10/txt/msg00715.txt.bz2

Tankut Baris Aktemur has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/139
......................................................................


Patch Set 1:

(1 comment)

https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/139/1//COMMIT_MSG 
Commit Message:

https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/139/1//COMMIT_MSG@12 
PS1, Line 12: 
> Can you make it explicit here why this is a good idea?
How about this? "... so that (1) the checks are grouped together at the beginning of the function for improved readability, and (2) we don't have to align and push things on the stack only to find out later that the function call is illegal."