* [review] Fix typo in symfile.c
@ 2019-10-19 5:01 Sergio Durigan Junior (Code Review)
2019-10-19 5:06 ` [review v2] Fix typos in symfile.c and i386-darwin-tdep.c Sergio Durigan Junior (Code Review)
` (9 more replies)
0 siblings, 10 replies; 11+ messages in thread
From: Sergio Durigan Junior (Code Review) @ 2019-10-19 5:01 UTC (permalink / raw)
To: gdb-patches; +Cc: Sergio Durigan Junior
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/161
......................................................................
Fix typo in symfile.c
This commit fixes a simple typo in gdb/symfile.c. s/wether/whether/.
2019-10-19 Sergio Durigan Junior <sergiodj@redhat.com>
* symfile.c (init_entry_point_info): Fix typo.
Change-Id: I1fbb39c32009c61c862b6bd56ce12f24a9edb2c4
---
M gdb/symfile.c
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gdb/symfile.c b/gdb/symfile.c
index 82081b1..f74c6de 100644
--- a/gdb/symfile.c
+++ b/gdb/symfile.c
@@ -908,7 +908,7 @@
corresponding BFD section index, or -1 if the section was not found.
ADD_FLAGS encodes verbosity level, whether this is main symbol or
- an extra symbol file such as dynamically loaded code, and wether
+ an extra symbol file such as dynamically loaded code, and whether
breakpoint reset should be deferred. */
static void
^ permalink raw reply [flat|nested] 11+ messages in thread
* [review v2] Fix typos in symfile.c and i386-darwin-tdep.c
2019-10-19 5:01 [review] Fix typo in symfile.c Sergio Durigan Junior (Code Review)
@ 2019-10-19 5:06 ` Sergio Durigan Junior (Code Review)
2019-10-19 5:06 ` [review] Fix typo in symfile.c Simon Marchi (Code Review)
` (8 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: Sergio Durigan Junior (Code Review) @ 2019-10-19 5:06 UTC (permalink / raw)
To: Sergio Durigan Junior, gdb-patches; +Cc: Simon Marchi
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/161
......................................................................
Fix typos in symfile.c and i386-darwin-tdep.c
This commit fixes two simple typos, one in gdb/symfile.c and the other
in gdb/i386-darwin-tdep.c. s/wether/whether/.
2019-10-19 Sergio Durigan Junior <sergiodj@redhat.com>
* symfile.c (init_entry_point_info): Fix typo.
* i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
Change-Id: I1fbb39c32009c61c862b6bd56ce12f24a9edb2c4
---
M gdb/i386-darwin-tdep.c
M gdb/symfile.c
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/gdb/i386-darwin-tdep.c b/gdb/i386-darwin-tdep.c
index 22653d3..6522a6f 100644
--- a/gdb/i386-darwin-tdep.c
+++ b/gdb/i386-darwin-tdep.c
@@ -104,7 +104,7 @@
return i386_sigtramp_p (this_frame);
}
-/* Check wether TYPE is a 128-bit vector (__m128, __m128d or __m128i). */
+/* Check whether TYPE is a 128-bit vector (__m128, __m128d or __m128i). */
static int
i386_m128_p (struct type *type)
diff --git a/gdb/symfile.c b/gdb/symfile.c
index 82081b1..f74c6de 100644
--- a/gdb/symfile.c
+++ b/gdb/symfile.c
@@ -908,7 +908,7 @@
corresponding BFD section index, or -1 if the section was not found.
ADD_FLAGS encodes verbosity level, whether this is main symbol or
- an extra symbol file such as dynamically loaded code, and wether
+ an extra symbol file such as dynamically loaded code, and whether
breakpoint reset should be deferred. */
static void
^ permalink raw reply [flat|nested] 11+ messages in thread
* [review] Fix typo in symfile.c
2019-10-19 5:01 [review] Fix typo in symfile.c Sergio Durigan Junior (Code Review)
2019-10-19 5:06 ` [review v2] Fix typos in symfile.c and i386-darwin-tdep.c Sergio Durigan Junior (Code Review)
@ 2019-10-19 5:06 ` Simon Marchi (Code Review)
2019-10-19 5:07 ` [review v2] Fix typos in symfile.c and i386-darwin-tdep.c Simon Marchi (Code Review)
` (7 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: Simon Marchi (Code Review) @ 2019-10-19 5:06 UTC (permalink / raw)
To: Sergio Durigan Junior, gdb-patches
Simon Marchi has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/161
......................................................................
Patch Set 1:
(1 comment)
This is a test.
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/161/1/gdb/symfile.c
File gdb/symfile.c:
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/161/1/gdb/symfile.c@911
PS1, Line 911: an extra symbol file such as dynamically loaded code, and whether
Test comment while there's only v1.
^ permalink raw reply [flat|nested] 11+ messages in thread
* [review v2] Fix typos in symfile.c and i386-darwin-tdep.c
2019-10-19 5:01 [review] Fix typo in symfile.c Sergio Durigan Junior (Code Review)
2019-10-19 5:06 ` [review v2] Fix typos in symfile.c and i386-darwin-tdep.c Sergio Durigan Junior (Code Review)
2019-10-19 5:06 ` [review] Fix typo in symfile.c Simon Marchi (Code Review)
@ 2019-10-19 5:07 ` Simon Marchi (Code Review)
2019-10-19 5:11 ` Simon Marchi (Code Review)
` (6 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: Simon Marchi (Code Review) @ 2019-10-19 5:07 UTC (permalink / raw)
To: Sergio Durigan Junior, gdb-patches
Simon Marchi has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/161
......................................................................
Patch Set 2:
(1 comment)
This is a test comment.
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/161/1/gdb/symfile.c
File gdb/symfile.c:
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/161/1/gdb/symfile.c@911
PS1, Line 911: an extra symbol file such as dynamically loaded code, and whether
> Test comment while there's only v1.
Test comment in v1 after v2 has been uploaded.
^ permalink raw reply [flat|nested] 11+ messages in thread
* [review v2] Fix typos in symfile.c and i386-darwin-tdep.c
2019-10-19 5:01 [review] Fix typo in symfile.c Sergio Durigan Junior (Code Review)
` (2 preceding siblings ...)
2019-10-19 5:07 ` [review v2] Fix typos in symfile.c and i386-darwin-tdep.c Simon Marchi (Code Review)
@ 2019-10-19 5:11 ` Simon Marchi (Code Review)
2019-10-19 5:14 ` [pushed] " Sourceware to Gerrit sync (Code Review)
` (5 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: Simon Marchi (Code Review) @ 2019-10-19 5:11 UTC (permalink / raw)
To: Sergio Durigan Junior, gdb-patches
Simon Marchi has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/161
......................................................................
Patch Set 2: Code-Review+2
^ permalink raw reply [flat|nested] 11+ messages in thread
* [pushed] Fix typos in symfile.c and i386-darwin-tdep.c
2019-10-19 5:01 [review] Fix typo in symfile.c Sergio Durigan Junior (Code Review)
` (3 preceding siblings ...)
2019-10-19 5:11 ` Simon Marchi (Code Review)
@ 2019-10-19 5:14 ` Sourceware to Gerrit sync (Code Review)
2019-10-19 5:14 ` Sourceware to Gerrit sync (Code Review)
` (4 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: Sourceware to Gerrit sync (Code Review) @ 2019-10-19 5:14 UTC (permalink / raw)
To: Sergio Durigan Junior, Simon Marchi, gdb-patches
The original change was created by Sergio Durigan Junior.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/161
......................................................................
Fix typos in symfile.c and i386-darwin-tdep.c
This commit fixes two simple typos, one in gdb/symfile.c and the other
in gdb/i386-darwin-tdep.c. s/wether/whether/.
2019-10-19 Sergio Durigan Junior <sergiodj@redhat.com>
* symfile.c (init_entry_point_info): Fix typo.
* i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
Change-Id: I1fbb39c32009c61c862b6bd56ce12f24a9edb2c4
---
M gdb/ChangeLog
M gdb/i386-darwin-tdep.c
M gdb/symfile.c
3 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index ea87d00..c6e516d 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2019-10-19 Sergio Durigan Junior <sergiodj@redhat.com>
+
+ * symfile.c (init_entry_point_info): Fix typo.
+ * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
+
2019-10-18 Tom de Vries <tdevries@suse.de>
* aarch64-tdep.c: Fix typos in comments.
diff --git a/gdb/i386-darwin-tdep.c b/gdb/i386-darwin-tdep.c
index 22653d3..6522a6f 100644
--- a/gdb/i386-darwin-tdep.c
+++ b/gdb/i386-darwin-tdep.c
@@ -104,7 +104,7 @@
return i386_sigtramp_p (this_frame);
}
-/* Check wether TYPE is a 128-bit vector (__m128, __m128d or __m128i). */
+/* Check whether TYPE is a 128-bit vector (__m128, __m128d or __m128i). */
static int
i386_m128_p (struct type *type)
diff --git a/gdb/symfile.c b/gdb/symfile.c
index 82081b1..f74c6de 100644
--- a/gdb/symfile.c
+++ b/gdb/symfile.c
@@ -908,7 +908,7 @@
corresponding BFD section index, or -1 if the section was not found.
ADD_FLAGS encodes verbosity level, whether this is main symbol or
- an extra symbol file such as dynamically loaded code, and wether
+ an extra symbol file such as dynamically loaded code, and whether
breakpoint reset should be deferred. */
static void
^ permalink raw reply [flat|nested] 11+ messages in thread
* [pushed] Fix typos in symfile.c and i386-darwin-tdep.c
2019-10-19 5:01 [review] Fix typo in symfile.c Sergio Durigan Junior (Code Review)
` (4 preceding siblings ...)
2019-10-19 5:14 ` [pushed] " Sourceware to Gerrit sync (Code Review)
@ 2019-10-19 5:14 ` Sourceware to Gerrit sync (Code Review)
2019-10-23 17:01 ` [review v3] " Sergio Durigan Junior (Code Review)
` (3 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: Sourceware to Gerrit sync (Code Review) @ 2019-10-19 5:14 UTC (permalink / raw)
To: Sergio Durigan Junior, gdb-patches; +Cc: Simon Marchi
Sourceware to Gerrit sync has submitted this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/161
......................................................................
Fix typos in symfile.c and i386-darwin-tdep.c
This commit fixes two simple typos, one in gdb/symfile.c and the other
in gdb/i386-darwin-tdep.c. s/wether/whether/.
2019-10-19 Sergio Durigan Junior <sergiodj@redhat.com>
* symfile.c (init_entry_point_info): Fix typo.
* i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
Change-Id: I1fbb39c32009c61c862b6bd56ce12f24a9edb2c4
---
M gdb/ChangeLog
M gdb/i386-darwin-tdep.c
M gdb/symfile.c
3 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index ea87d00..c6e516d 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2019-10-19 Sergio Durigan Junior <sergiodj@redhat.com>
+
+ * symfile.c (init_entry_point_info): Fix typo.
+ * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
+
2019-10-18 Tom de Vries <tdevries@suse.de>
* aarch64-tdep.c: Fix typos in comments.
diff --git a/gdb/i386-darwin-tdep.c b/gdb/i386-darwin-tdep.c
index 22653d3..6522a6f 100644
--- a/gdb/i386-darwin-tdep.c
+++ b/gdb/i386-darwin-tdep.c
@@ -104,7 +104,7 @@
return i386_sigtramp_p (this_frame);
}
-/* Check wether TYPE is a 128-bit vector (__m128, __m128d or __m128i). */
+/* Check whether TYPE is a 128-bit vector (__m128, __m128d or __m128i). */
static int
i386_m128_p (struct type *type)
diff --git a/gdb/symfile.c b/gdb/symfile.c
index 82081b1..f74c6de 100644
--- a/gdb/symfile.c
+++ b/gdb/symfile.c
@@ -908,7 +908,7 @@
corresponding BFD section index, or -1 if the section was not found.
ADD_FLAGS encodes verbosity level, whether this is main symbol or
- an extra symbol file such as dynamically loaded code, and wether
+ an extra symbol file such as dynamically loaded code, and whether
breakpoint reset should be deferred. */
static void
^ permalink raw reply [flat|nested] 11+ messages in thread
* [review v3] Fix typos in symfile.c and i386-darwin-tdep.c
2019-10-19 5:01 [review] Fix typo in symfile.c Sergio Durigan Junior (Code Review)
` (5 preceding siblings ...)
2019-10-19 5:14 ` Sourceware to Gerrit sync (Code Review)
@ 2019-10-23 17:01 ` Sergio Durigan Junior (Code Review)
2019-10-23 22:00 ` Sergio Durigan Junior (Code Review)
` (2 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: Sergio Durigan Junior (Code Review) @ 2019-10-23 17:01 UTC (permalink / raw)
To: Sergio Durigan Junior, gdb-patches; +Cc: Simon Marchi
Sergio Durigan Junior has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/161
......................................................................
Patch Set 3:
This is a test comment.
^ permalink raw reply [flat|nested] 11+ messages in thread
* [review v3] Fix typos in symfile.c and i386-darwin-tdep.c
2019-10-19 5:01 [review] Fix typo in symfile.c Sergio Durigan Junior (Code Review)
` (6 preceding siblings ...)
2019-10-23 17:01 ` [review v3] " Sergio Durigan Junior (Code Review)
@ 2019-10-23 22:00 ` Sergio Durigan Junior (Code Review)
2019-10-23 22:02 ` Sergio Durigan Junior (Code Review)
2019-10-25 1:58 ` Sergio Durigan Junior (Code Review)
9 siblings, 0 replies; 11+ messages in thread
From: Sergio Durigan Junior (Code Review) @ 2019-10-23 22:00 UTC (permalink / raw)
To: Sergio Durigan Junior, gdb-patches; +Cc: Simon Marchi
Sergio Durigan Junior has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/161
......................................................................
Patch Set 3:
This is another test comment.
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I1fbb39c32009c61c862b6bd56ce12f24a9edb2c4
Gerrit-Change-Number: 161
Gerrit-PatchSet: 3
Gerrit-Owner: Sergio Durigan Junior <sergiodj@redhat.com>
Gerrit-Reviewer: Sergio Durigan Junior <sergiodj@redhat.com>
Gerrit-Reviewer: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-Comment-Date: Wed, 23 Oct 2019 22:00:40 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
^ permalink raw reply [flat|nested] 11+ messages in thread
* [review v3] Fix typos in symfile.c and i386-darwin-tdep.c
2019-10-19 5:01 [review] Fix typo in symfile.c Sergio Durigan Junior (Code Review)
` (7 preceding siblings ...)
2019-10-23 22:00 ` Sergio Durigan Junior (Code Review)
@ 2019-10-23 22:02 ` Sergio Durigan Junior (Code Review)
2019-10-25 1:58 ` Sergio Durigan Junior (Code Review)
9 siblings, 0 replies; 11+ messages in thread
From: Sergio Durigan Junior (Code Review) @ 2019-10-23 22:02 UTC (permalink / raw)
To: Sergio Durigan Junior, gdb-patches; +Cc: Simon Marchi
Sergio Durigan Junior has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/161
......................................................................
Patch Set 3:
On Wednesday, October 23 2019, Sergio Durigan Junior wrote:
And this is a test reply, sent by e-mail.
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I1fbb39c32009c61c862b6bd56ce12f24a9edb2c4
Gerrit-Change-Number: 161
Gerrit-PatchSet: 3
Gerrit-Owner: Sergio Durigan Junior <sergiodj@redhat.com>
Gerrit-Reviewer: Sergio Durigan Junior <sergiodj@redhat.com>
Gerrit-Reviewer: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-Comment-Date: Wed, 23 Oct 2019 22:02:23 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
^ permalink raw reply [flat|nested] 11+ messages in thread
* [review v3] Fix typos in symfile.c and i386-darwin-tdep.c
2019-10-19 5:01 [review] Fix typo in symfile.c Sergio Durigan Junior (Code Review)
` (8 preceding siblings ...)
2019-10-23 22:02 ` Sergio Durigan Junior (Code Review)
@ 2019-10-25 1:58 ` Sergio Durigan Junior (Code Review)
9 siblings, 0 replies; 11+ messages in thread
From: Sergio Durigan Junior (Code Review) @ 2019-10-25 1:58 UTC (permalink / raw)
To: Sergio Durigan Junior, gdb-patches; +Cc: Simon Marchi
Sergio Durigan Junior has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/161
......................................................................
Patch Set 3:
This is a change with a very long line that doesn't wrap here but should wrap automatically in the email message when gerrit sends it through the SMTP server configured in the config file, yes.
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I1fbb39c32009c61c862b6bd56ce12f24a9edb2c4
Gerrit-Change-Number: 161
Gerrit-PatchSet: 3
Gerrit-Owner: Sergio Durigan Junior <sergiodj@redhat.com>
Gerrit-Reviewer: Sergio Durigan Junior <sergiodj@redhat.com>
Gerrit-Reviewer: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-Comment-Date: Fri, 25 Oct 2019 01:58:09 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2019-10-25 1:58 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-19 5:01 [review] Fix typo in symfile.c Sergio Durigan Junior (Code Review)
2019-10-19 5:06 ` [review v2] Fix typos in symfile.c and i386-darwin-tdep.c Sergio Durigan Junior (Code Review)
2019-10-19 5:06 ` [review] Fix typo in symfile.c Simon Marchi (Code Review)
2019-10-19 5:07 ` [review v2] Fix typos in symfile.c and i386-darwin-tdep.c Simon Marchi (Code Review)
2019-10-19 5:11 ` Simon Marchi (Code Review)
2019-10-19 5:14 ` [pushed] " Sourceware to Gerrit sync (Code Review)
2019-10-19 5:14 ` Sourceware to Gerrit sync (Code Review)
2019-10-23 17:01 ` [review v3] " Sergio Durigan Junior (Code Review)
2019-10-23 22:00 ` Sergio Durigan Junior (Code Review)
2019-10-23 22:02 ` Sergio Durigan Junior (Code Review)
2019-10-25 1:58 ` Sergio Durigan Junior (Code Review)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox