From: "Simon Marchi (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>
To: Christian Biesinger <cbiesinger@google.com>, gdb-patches@sourceware.org
Cc: Tom Tromey <tromey@sourceware.org>
Subject: [review] Replace some more qsort calls with std::sort
Date: Sat, 19 Oct 2019 04:32:00 -0000 [thread overview]
Message-ID: <20191019043200.F332720AF6@gnutoolchain-gerrit.osci.io> (raw)
In-Reply-To: <gerrit.1571352182000.Ibcddce12a3d07448701e731b7150fa23611d86de@gnutoolchain-gerrit.osci.io>
Simon Marchi has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/131
......................................................................
Patch Set 2:
(1 comment)
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/131/1/gdb/breakpoint.c
File gdb/breakpoint.c:
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/131/1/gdb/breakpoint.c@522
PS1, Line 522: /* Array is sorted by bp_location_is_less_than - primarily by the ADDRESS. */
> When you're logged in, you can set diff preferences using the "gear" icon on the right, where you ca […]
Tom, I have made a change that should make the line length 80 columns for all users that haven't set it themselves. You should therefore see a guide at column 80. Please tell me if that worked (unless you have already changed it yourself, then we'll need to ask somebody else).
next prev parent reply other threads:[~2019-10-19 4:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-17 22:43 Christian Biesinger (Code Review)
2019-10-18 13:47 ` Tom Tromey (Code Review)
2019-10-18 21:40 ` Christian Biesinger (Code Review)
2019-10-18 21:41 ` Christian Biesinger (Code Review)
2019-10-19 4:32 ` Simon Marchi (Code Review) [this message]
2019-10-19 20:43 ` [review v2] " Tom Tromey (Code Review)
2019-10-19 20:47 ` [pushed] " Sourceware to Gerrit sync (Code Review)
2019-10-19 20:47 ` Sourceware to Gerrit sync (Code Review)
2019-10-21 4:45 ` [review v3] " Simon Marchi (Code Review)
2019-10-21 16:22 ` Christian Biesinger (Code Review)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191019043200.F332720AF6@gnutoolchain-gerrit.osci.io \
--to=gerrit@gnutoolchain-gerrit.osci.io \
--cc=cbiesinger@google.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
--cc=tromey@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox