From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 85684 invoked by alias); 19 Oct 2019 04:32:07 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 85671 invoked by uid 89); 19 Oct 2019 04:32:07 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-7.1 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.1 spammy=yourself, HContent-Transfer-Encoding:8bit X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 19 Oct 2019 04:32:06 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id 7215E204F8; Sat, 19 Oct 2019 00:32:02 -0400 (EDT) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [8.43.85.239]) by mx1.osci.io (Postfix) with ESMTP id 20D45206FC; Sat, 19 Oct 2019 00:32:01 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id F332720AF6; Sat, 19 Oct 2019 00:32:00 -0400 (EDT) X-Gerrit-PatchSet: 2 Date: Sat, 19 Oct 2019 04:32:00 -0000 From: "Simon Marchi (Code Review)" To: Christian Biesinger , gdb-patches@sourceware.org Cc: Tom Tromey Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review] Replace some more qsort calls with std::sort X-Gerrit-Change-Id: Ibcddce12a3d07448701e731b7150fa23611d86de X-Gerrit-Change-Number: 131 X-Gerrit-ChangeURL: X-Gerrit-Commit: 349f7f4d7fb446acf95d025f588a37c9cf96dcbd In-Reply-To: References: X-Gerrit-Comment-Date: Sat, 19 Oct 2019 00:32:00 -0400 Reply-To: simon.marchi@polymtl.ca, tromey@sourceware.org, cbiesinger@google.com, gdb-patches@sourceware.org MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3 Content-Type: text/plain; charset=UTF-8 Message-Id: <20191019043200.F332720AF6@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-10/txt/msg00649.txt.bz2 Simon Marchi has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/131 ...................................................................... Patch Set 2: (1 comment) https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/131/1/gdb/breakpoint.c File gdb/breakpoint.c: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/131/1/gdb/breakpoint.c@522 PS1, Line 522: /* Array is sorted by bp_location_is_less_than - primarily by the ADDRESS. */ > When you're logged in, you can set diff preferences using the "gear" icon on the right, where you ca […] Tom, I have made a change that should make the line length 80 columns for all users that haven't set it themselves. You should therefore see a guide at column 80. Please tell me if that worked (unless you have already changed it yourself, then we'll need to ask somebody else).