From: "Simon Marchi (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>
To: Tom de Vries <tdevries@suse.de>, gdb-patches@sourceware.org
Subject: Change in binutils-gdb[master]: [gdb/tdep] Fix inferior call arg passing for amd64
Date: Tue, 15 Oct 2019 12:46:00 -0000 [thread overview]
Message-ID: <20191015124613.413D929ECF@gnutoolchain-gerrit.osci.io> (raw)
In-Reply-To: <gerrit.1571043259000.Id55c74755f0a431ce31223acc86865718ae0c123@gnutoolchain-gerrit.osci.io>
Simon Marchi has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/31
......................................................................
Patch Set 1:
(1 comment)
So, it LGTM, but is there anybody else that you think should review it? Andrew or Alan perhaps?
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/31/1/gdb/amd64-tdep.c
File gdb/amd64-tdep.c:
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/31/1/gdb/amd64-tdep.c@645
PS1, Line 645: theclass[1] = amd64_merge_classes (theclass[1], subclass[1]);
> Doing: […]
Ah ok that makes it clear. I thought that non-aggregate fields would always just use the first eightbyte, therefore just set subclass[0] and leave subclass[1] untouched. But that's not the case, so nevermind.
--
To view, visit https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/31
To unsubscribe, or for help writing mail filters, visit https://gnutoolchain-gerrit.osci.io/r/settings
next prev parent reply other threads:[~2019-10-15 12:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <gerrit.1571043259000.Id55c74755f0a431ce31223acc86865718ae0c123@gnutoolchain-gerrit.osci.io>
2019-10-15 4:54 ` Simon Marchi (Code Review)
2019-10-15 9:11 ` Tom de Vries (Code Review)
2019-10-15 12:46 ` Simon Marchi (Code Review) [this message]
2019-10-15 13:05 ` Andrew Burgess (Code Review)
2019-10-15 13:52 ` Tom de Vries (Code Review)
2019-10-15 16:02 ` Simon Marchi (Code Review)
2019-10-16 15:13 ` [review] " Sourceware to Gerrit sync (Code Review)
2019-10-16 15:13 ` Sourceware to Gerrit sync (Code Review)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191015124613.413D929ECF@gnutoolchain-gerrit.osci.io \
--to=gerrit@gnutoolchain-gerrit.osci.io \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox