* Change in binutils-gdb[master]: [RFC][gdb] Make script-extension strict reject unknown extensions
[not found] <gerrit.1571060583000.Ia357a4b0b1042808401578266da80919035ad576@gnutoolchain-gerrit.osci.io>
@ 2019-10-14 16:08 ` Christian Biesinger (Code Review)
2019-10-14 17:41 ` Tom de Vries (Code Review)
1 sibling, 0 replies; 2+ messages in thread
From: Christian Biesinger (Code Review) @ 2019-10-14 16:08 UTC (permalink / raw)
To: Tom de Vries, gdb-patches; +Cc: Christian Biesinger
Christian Biesinger has posted comments on this change. ( https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/40 )
Change subject: [RFC][gdb] Make script-extension strict reject unknown extensions
......................................................................
Patch Set 1:
A couple questions about this:
- If specified in -ix or a system gdbinit file, does it prevent reading ~/.gdbinit?
- Does it prevent reading a file in --command if it doesn't have the extension?
--
To view, visit https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/40
To unsubscribe, or for help writing mail filters, visit https://gnutoolchain-gerrit.osci.io/r/settings
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: Ia357a4b0b1042808401578266da80919035ad576
Gerrit-Change-Number: 40
Gerrit-PatchSet: 1
Gerrit-Owner: Tom de Vries <tdevries@suse.de>
Gerrit-Reviewer: Tom de Vries <tdevries@suse.de>
Gerrit-CC: Christian Biesinger <cbiesinger@google.com>
Gerrit-Comment-Date: Mon, 14 Oct 2019 16:08:20 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
^ permalink raw reply [flat|nested] 2+ messages in thread* Change in binutils-gdb[master]: [RFC][gdb] Make script-extension strict reject unknown extensions
[not found] <gerrit.1571060583000.Ia357a4b0b1042808401578266da80919035ad576@gnutoolchain-gerrit.osci.io>
2019-10-14 16:08 ` Change in binutils-gdb[master]: [RFC][gdb] Make script-extension strict reject unknown extensions Christian Biesinger (Code Review)
@ 2019-10-14 17:41 ` Tom de Vries (Code Review)
1 sibling, 0 replies; 2+ messages in thread
From: Tom de Vries (Code Review) @ 2019-10-14 17:41 UTC (permalink / raw)
To: gdb-patches; +Cc: Christian Biesinger
Tom de Vries has posted comments on this change. ( https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/40 )
Change subject: [RFC][gdb] Make script-extension strict reject unknown extensions
......................................................................
Patch Set 1:
> Patch Set 1:
>
> A couple questions about this:
> - If specified in -ix or a system gdbinit file, does it prevent reading ~/.gdbinit?
I marked ~/.gdbinit execution using:
...
$ cat ~/.gdbinit
python
print ("HERE")
...
And using this command I can see iex is executed after ~/.gdbinit:
...
$ gdb -q -batch -iex "echo bla1\n" -iex "set script-extension strict" -iex "echo bla2\n"
HERE
bla1
bla2
...
But for the system gdbinit, it's yes.
> - Does it prevent reading a file in --command if it doesn't have the extension?
Yes:
...
$ gdb -batch -q -ex "set script-extension strict" --command=bla.bla
Scripting in the "<UNKNOWN>" language is not supported in this copy of GDB.
....
--
To view, visit https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/40
To unsubscribe, or for help writing mail filters, visit https://gnutoolchain-gerrit.osci.io/r/settings
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: Ia357a4b0b1042808401578266da80919035ad576
Gerrit-Change-Number: 40
Gerrit-PatchSet: 1
Gerrit-Owner: Tom de Vries <tdevries@suse.de>
Gerrit-Reviewer: Tom de Vries <tdevries@suse.de>
Gerrit-CC: Christian Biesinger <cbiesinger@google.com>
Gerrit-Comment-Date: Mon, 14 Oct 2019 17:41:45 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-10-14 17:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <gerrit.1571060583000.Ia357a4b0b1042808401578266da80919035ad576@gnutoolchain-gerrit.osci.io>
2019-10-14 16:08 ` Change in binutils-gdb[master]: [RFC][gdb] Make script-extension strict reject unknown extensions Christian Biesinger (Code Review)
2019-10-14 17:41 ` Tom de Vries (Code Review)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox