From: Kevin Buettner <kevinb@redhat.com>
To: gdb-patches@sourceware.org
Cc: Tom Tromey <tom@tromey.com>
Subject: Re: [PATCH] Fix stepping bug associated with non-contiguous blocks
Date: Mon, 15 Jul 2019 21:11:00 -0000 [thread overview]
Message-ID: <20190715141116.6d240805@f29-4.lan> (raw)
In-Reply-To: <87ef2r9vd5.fsf@tromey.com>
On Mon, 15 Jul 2019 09:21:26 -0600
Tom Tromey <tom@tromey.com> wrote:
> >>>>> "Kevin" == Kevin Buettner <kevinb@redhat.com> writes:
>
> Kevin> gdb/ChangeLog:
>
> Kevin> * infrun.c (fill_in_stop_func): Use find_pc_partial_function
> Kevin> instead of find_function_entry_range_from_pc.
>
> Thanks for the explanation. I think this makes sense.
Thanks for the review.
> Kevin> + ecs->stop_func_start
> Kevin> + += gdbarch_deprecated_function_start_offset (gdbarch);
>
> This hook is only used by VAX. I wonder if we could delete it somehow.
I had to refresh my memory on what this was about. On VAX, the CALL
instruction's target consists of a 16-bit entry mask followed by the
instructions that we'd normally expect to see. The entry mask specifies
the registers which should be pushed (plus some other stuff too, I think.)
Do we still care about the VAX target?
If not, once the VAX target is deleted, that hook could be deleted too.
Kevin
next prev parent reply other threads:[~2019-07-15 21:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-14 0:01 Kevin Buettner
2019-07-15 15:21 ` Tom Tromey
2019-07-15 21:11 ` Kevin Buettner [this message]
2019-07-15 21:53 ` Kevin Buettner
2019-07-18 13:36 ` Tom Tromey
2019-07-27 20:49 ` Kevin Buettner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190715141116.6d240805@f29-4.lan \
--to=kevinb@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox