From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 39610 invoked by alias); 15 Jul 2019 21:11:20 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 39601 invoked by uid 89); 15 Jul 2019 21:11:19 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-4.2 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=H*M:lan, HX-Languages-Length:1015, consists X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 15 Jul 2019 21:11:18 +0000 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 3F9FC8553A; Mon, 15 Jul 2019 21:11:17 +0000 (UTC) Received: from f29-4.lan (ovpn-117-224.phx2.redhat.com [10.3.117.224]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 153AA600C1; Mon, 15 Jul 2019 21:11:17 +0000 (UTC) Date: Mon, 15 Jul 2019 21:11:00 -0000 From: Kevin Buettner To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: Re: [PATCH] Fix stepping bug associated with non-contiguous blocks Message-ID: <20190715141116.6d240805@f29-4.lan> In-Reply-To: <87ef2r9vd5.fsf@tromey.com> References: <20190714000108.15420-1-kevinb@redhat.com> <87ef2r9vd5.fsf@tromey.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2019-07/txt/msg00367.txt.bz2 On Mon, 15 Jul 2019 09:21:26 -0600 Tom Tromey wrote: > >>>>> "Kevin" == Kevin Buettner writes: > > Kevin> gdb/ChangeLog: > > Kevin> * infrun.c (fill_in_stop_func): Use find_pc_partial_function > Kevin> instead of find_function_entry_range_from_pc. > > Thanks for the explanation. I think this makes sense. Thanks for the review. > Kevin> + ecs->stop_func_start > Kevin> + += gdbarch_deprecated_function_start_offset (gdbarch); > > This hook is only used by VAX. I wonder if we could delete it somehow. I had to refresh my memory on what this was about. On VAX, the CALL instruction's target consists of a 16-bit entry mask followed by the instructions that we'd normally expect to see. The entry mask specifies the registers which should be pushed (plus some other stuff too, I think.) Do we still care about the VAX target? If not, once the VAX target is deleted, that hook could be deleted too. Kevin