From: Kevin Buettner <kevinb@redhat.com>
To: Tom de Vries <tdevries@suse.de>
Cc: gdb-patches@sourceware.org, Pedro Alves <palves@redhat.com>
Subject: Re: [PING][PATCH] Fix amd64->i386 linux syscall restart problem
Date: Fri, 12 Jul 2019 12:24:00 -0000 [thread overview]
Message-ID: <20190712052349.380f369f@f29-4.lan> (raw)
In-Reply-To: <54a90435-e80e-6028-1007-db4423669850@suse.de>
Hi Tom,
Yes, that's right, those two commits are needed. I've looked it over. It
looks good to me.
Kevin
On Fri, 12 Jul 2019 13:42:51 +0200
Tom de Vries <tdevries@suse.de> wrote:
> On 08-07-19 19:00, Kevin Buettner wrote:
> >
> > On Fri, 21 Jun 2019 08:34:46 +0200
> > Tom de Vries <tdevries@suse.de> wrote:
> >
> >> On 21-05-19 14:59, Tom de Vries wrote:
> >>> On 11-04-19 02:16, Kevin Buettner wrote:
> >>>> On Wed, 10 Apr 2019 12:42:30 +0100
> >>>> Pedro Alves <palves@redhat.com> wrote:
> >>>>
> >>>>>> Below is a diff showing the new comments. It also includes the
> >>>>>> changes which wrap the multi-line expressions in parens.
> >>>>>
> >>>>> Thanks, that new version of the comment looks great.
> >>>>
> >>>> It's in now. Thanks for the review.
> >>>
> >>> Hi,
> >>>
> >>> the tests fixed by this commit fail on the 8.3 branch (filed as PR24592).
> >>>
> >>> The commit applies cleanly on the 8.3 branch, and make the tests pass.
> >>>
> >>> OK to backport?
> >>
> >> Hi,
> >>
> >> [ Ping. ]
> >>
> >> I'm probably missing some context here. It seems sofar there are no
> >> commits to the 8.3 branch. AFAIU, a respin release 8.3.1 is targeted for
> >> 3 months after 8.3, so around 11th of August.
> >>
> >> What kind of fixes are acceptable for the respin? Do they have to be
> >> regression fixes? Or are functionality fixes like this one also allowed?
> >> Who's responsibility is it to backport fixes?
> >>
> >> Thanks,
> >> - Tom
> >
> > I'm okay with it going into the next point release for 8.3.
>
> Hi Kevin,
>
> I noticed the follow-up commit e90a813d96 "Fix regression caused by
> recently added syscall restart code". I reproduced the regression with
> the 8.3 branch + commit 3f52fdbcb5, and confirmed that the follow-up
> commit fixes it, so I suppose this one is necessary as well.
>
> Since this is the first time I'm pushing something to a gdb release
> branch, I'm posting here the two pre-commit-formatted patches for review.
>
> Thanks,
> - Tom
>
>
prev parent reply other threads:[~2019-07-12 12:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-17 5:13 [PATCH] " Kevin Buettner
2019-04-04 16:51 ` Kevin Buettner
2019-04-09 17:46 ` Pedro Alves
2019-04-10 2:29 ` Kevin Buettner
2019-04-10 11:42 ` Pedro Alves
2019-04-11 0:16 ` Kevin Buettner
2019-05-21 12:59 ` Tom de Vries
2019-06-21 6:34 ` [PING][PATCH] " Tom de Vries
2019-07-08 17:00 ` Kevin Buettner
2019-07-12 11:42 ` Tom de Vries
2019-07-12 12:24 ` Kevin Buettner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190712052349.380f369f@f29-4.lan \
--to=kevinb@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox