* Recent changes broke the or1k simulator support
@ 2019-06-13 12:05 Sebastian Huber
2019-06-13 12:19 ` Stafford Horne
0 siblings, 1 reply; 4+ messages in thread
From: Sebastian Huber @ 2019-06-13 12:05 UTC (permalink / raw)
To: GDB patches; +Cc: Stafford Horne
Hello,
a recent change (within one week) broke the or1k simulator support:
gmake[3]: Entering directory
'/usr/home/user/rtems-source-builder/rtems/build/or1k-rtems6-gdb-e41d1c49a1-x86_64-freebsd12.0-1/build/sim/or1k'
/usr/bin/cc -O2 -pipe -fbracket-depth=1024
-I/usr/home/user/rtems-source-builder/rtems/build/tmp/sb-user/6/rtems-or1k.bset/usr/local/rtems/5/include
-DHAVE_CONFIG_H -DWITH_DEFAULT_MODEL='"or1200"'
-DWITH_ALIGNMENT=STRICT_ALIGNMENT -DWITH_TARGET_WORD_BITSIZE=32
-DWITH_TARGET_WORD_MSB=31 -DWITH_TARGET_ADDRESS_BITSIZE=32
-DWITH_TARGET_BYTE_ORDER=BFD_ENDIAN_BIG -DDEFAULT_INLINE=0
-DWITH_SCACHE=16384 -I.
-I../../../sourceware-mirror-binutils-gdb-e41d1c49a1/sim/or1k
-I../common
-I../../../sourceware-mirror-binutils-gdb-e41d1c49a1/sim/or1k/../common
-I../../include
-I../../../sourceware-mirror-binutils-gdb-e41d1c49a1/sim/or1k/../../include
-I../../bfd
-I../../../sourceware-mirror-binutils-gdb-e41d1c49a1/sim/or1k/../../bfd
-I../../opcodes
-I../../../sourceware-mirror-binutils-gdb-e41d1c49a1/sim/or1k/../../opcodes
-c -o decode.o -MT decode.o -MMD -MP -MF .deps/decode.Tpo
../../../sourceware-mirror-binutils-gdb-e41d1c49a1/sim/or1k/decode.c
../../../sourceware-mirror-binutils-gdb-e41d1c49a1/sim/or1k/decode.c:153:5:
error: use of undeclared identifier 'OR1K_INSN_LF_EQ_S'
{ OR1K_INSN_LF_EQ_S, OR1K32BF_INSN_LF_EQ_S, OR1K32BF_SFMT_LF_EQ_S },
^
../../../sourceware-mirror-binutils-gdb-e41d1c49a1/sim/or1k/decode.c:154:5:
error: use of undeclared identifier 'OR1K_INSN_LF_NE_S'
{ OR1K_INSN_LF_NE_S, OR1K32BF_INSN_LF_NE_S, OR1K32BF_SFMT_LF_EQ_S },
^
../../../sourceware-mirror-binutils-gdb-e41d1c49a1/sim/or1k/decode.c:155:5:
error: use of undeclared identifier 'OR1K_INSN_LF_GE_S'
{ OR1K_INSN_LF_GE_S, OR1K32BF_INSN_LF_GE_S, OR1K32BF_SFMT_LF_EQ_S },
^
../../../sourceware-mirror-binutils-gdb-e41d1c49a1/sim/or1k/decode.c:156:5:
error: use of undeclared identifier 'OR1K_INSN_LF_GT_S'; did you mean
'OR1K_INSN_LF_SFGT_S'?
{ OR1K_INSN_LF_GT_S, OR1K32BF_INSN_LF_GT_S, OR1K32BF_SFMT_LF_EQ_S },
^~~~~~~~~~~~~~~~~
OR1K_INSN_LF_SFGT_S
../../../sourceware-mirror-binutils-gdb-e41d1c49a1/sim/or1k/../../opcodes/or1k-opc.h:80:27:
note: 'OR1K_INSN_LF_SFGT_S' declared here
, OR1K_INSN_LF_SFGE_D32, OR1K_INSN_LF_SFGT_S, OR1K_INSN_LF_SFGT_D,
OR1K_INSN_LF_SFGT_D32
Please let me know if you need more details.
--
Sebastian Huber, embedded brains GmbH
Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone : +49 89 189 47 41-16
Fax : +49 89 189 47 41-09
E-Mail : sebastian.huber@embedded-brains.de
PGP : Public key available on request.
Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Recent changes broke the or1k simulator support
2019-06-13 12:05 Recent changes broke the or1k simulator support Sebastian Huber
@ 2019-06-13 12:19 ` Stafford Horne
2019-06-13 12:24 ` Sebastian Huber
0 siblings, 1 reply; 4+ messages in thread
From: Stafford Horne @ 2019-06-13 12:19 UTC (permalink / raw)
To: Sebastian Huber; +Cc: GDB patches
On Thu, Jun 13, 2019 at 02:05:19PM +0200, Sebastian Huber wrote:
> Hello,
>
> a recent change (within one week) broke the or1k simulator support:
Hello,
Sorry about this, I had a patch series of binutils + sim patches. I submitted
the binutils part, but was waiting for approval on the sim part. It escaped my
mind that committing the bin only part would cause the sim to break.
I can just commit the sim part now as the review was done before, I was just
waiting for a final OK.
-Stafford
> gmake[3]: Entering directory '/usr/home/user/rtems-source-builder/rtems/build/or1k-rtems6-gdb-e41d1c49a1-x86_64-freebsd12.0-1/build/sim/or1k'
> /usr/bin/cc -O2 -pipe -fbracket-depth=1024 -I/usr/home/user/rtems-source-builder/rtems/build/tmp/sb-user/6/rtems-or1k.bset/usr/local/rtems/5/include
> -DHAVE_CONFIG_H -DWITH_DEFAULT_MODEL='"or1200"'
> -DWITH_ALIGNMENT=STRICT_ALIGNMENT -DWITH_TARGET_WORD_BITSIZE=32
> -DWITH_TARGET_WORD_MSB=31 -DWITH_TARGET_ADDRESS_BITSIZE=32
> -DWITH_TARGET_BYTE_ORDER=BFD_ENDIAN_BIG -DDEFAULT_INLINE=0
> -DWITH_SCACHE=16384 -I.
> -I../../../sourceware-mirror-binutils-gdb-e41d1c49a1/sim/or1k -I../common
> -I../../../sourceware-mirror-binutils-gdb-e41d1c49a1/sim/or1k/../common
> -I../../include
> -I../../../sourceware-mirror-binutils-gdb-e41d1c49a1/sim/or1k/../../include
> -I../../bfd
> -I../../../sourceware-mirror-binutils-gdb-e41d1c49a1/sim/or1k/../../bfd
> -I../../opcodes
> -I../../../sourceware-mirror-binutils-gdb-e41d1c49a1/sim/or1k/../../opcodes
> -c -o decode.o -MT decode.o -MMD -MP -MF .deps/decode.Tpo
> ../../../sourceware-mirror-binutils-gdb-e41d1c49a1/sim/or1k/decode.c
> ../../../sourceware-mirror-binutils-gdb-e41d1c49a1/sim/or1k/decode.c:153:5:
> error: use of undeclared identifier 'OR1K_INSN_LF_EQ_S'
> { OR1K_INSN_LF_EQ_S, OR1K32BF_INSN_LF_EQ_S, OR1K32BF_SFMT_LF_EQ_S },
> ^
> ../../../sourceware-mirror-binutils-gdb-e41d1c49a1/sim/or1k/decode.c:154:5:
> error: use of undeclared identifier 'OR1K_INSN_LF_NE_S'
> { OR1K_INSN_LF_NE_S, OR1K32BF_INSN_LF_NE_S, OR1K32BF_SFMT_LF_EQ_S },
> ^
> ../../../sourceware-mirror-binutils-gdb-e41d1c49a1/sim/or1k/decode.c:155:5:
> error: use of undeclared identifier 'OR1K_INSN_LF_GE_S'
> { OR1K_INSN_LF_GE_S, OR1K32BF_INSN_LF_GE_S, OR1K32BF_SFMT_LF_EQ_S },
> ^
> ../../../sourceware-mirror-binutils-gdb-e41d1c49a1/sim/or1k/decode.c:156:5:
> error: use of undeclared identifier 'OR1K_INSN_LF_GT_S'; did you mean
> 'OR1K_INSN_LF_SFGT_S'?
> { OR1K_INSN_LF_GT_S, OR1K32BF_INSN_LF_GT_S, OR1K32BF_SFMT_LF_EQ_S },
> ^~~~~~~~~~~~~~~~~
> OR1K_INSN_LF_SFGT_S
> ../../../sourceware-mirror-binutils-gdb-e41d1c49a1/sim/or1k/../../opcodes/or1k-opc.h:80:27:
> note: 'OR1K_INSN_LF_SFGT_S' declared here
> , OR1K_INSN_LF_SFGE_D32, OR1K_INSN_LF_SFGT_S, OR1K_INSN_LF_SFGT_D,
> OR1K_INSN_LF_SFGT_D32
>
> Please let me know if you need more details.
>
> --
> Sebastian Huber, embedded brains GmbH
>
> Address : Dornierstr. 4, D-82178 Puchheim, Germany
> Phone : +49 89 189 47 41-16
> Fax : +49 89 189 47 41-09
> E-Mail : sebastian.huber@embedded-brains.de
> PGP : Public key available on request.
>
> Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Recent changes broke the or1k simulator support
2019-06-13 12:19 ` Stafford Horne
@ 2019-06-13 12:24 ` Sebastian Huber
2019-06-13 12:29 ` Stafford Horne
0 siblings, 1 reply; 4+ messages in thread
From: Sebastian Huber @ 2019-06-13 12:24 UTC (permalink / raw)
To: Stafford Horne; +Cc: GDB patches
On 13/06/2019 14:19, Stafford Horne wrote:
> On Thu, Jun 13, 2019 at 02:05:19PM +0200, Sebastian Huber wrote:
>> Hello,
>>
>> a recent change (within one week) broke the or1k simulator support:
> Hello,
>
> Sorry about this, I had a patch series of binutils + sim patches. I submitted
> the binutils part, but was waiting for approval on the sim part. It escaped my
> mind that committing the bin only part would cause the sim to break.
>
> I can just commit the sim part now as the review was done before, I was just
> waiting for a final OK.
Ok, no problem. I will check it again next week. I just wanted to make
sure that this didn't slip through.
--
Sebastian Huber, embedded brains GmbH
Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone : +49 89 189 47 41-16
Fax : +49 89 189 47 41-09
E-Mail : sebastian.huber@embedded-brains.de
PGP : Public key available on request.
Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Recent changes broke the or1k simulator support
2019-06-13 12:24 ` Sebastian Huber
@ 2019-06-13 12:29 ` Stafford Horne
0 siblings, 0 replies; 4+ messages in thread
From: Stafford Horne @ 2019-06-13 12:29 UTC (permalink / raw)
To: Sebastian Huber; +Cc: GDB patches
On Thu, Jun 13, 2019 at 02:24:15PM +0200, Sebastian Huber wrote:
> On 13/06/2019 14:19, Stafford Horne wrote:
> > On Thu, Jun 13, 2019 at 02:05:19PM +0200, Sebastian Huber wrote:
> > > Hello,
> > >
> > > a recent change (within one week) broke the or1k simulator support:
> > Hello,
> >
> > Sorry about this, I had a patch series of binutils + sim patches. I submitted
> > the binutils part, but was waiting for approval on the sim part. It escaped my
> > mind that committing the bin only part would cause the sim to break.
> >
> > I can just commit the sim part now as the review was done before, I was just
> > waiting for a final OK.
>
> Ok, no problem. I will check it again next week. I just wanted to make sure
> that this didn't slip through.
No problem,
Seeing that most of the changes except a trivial one were already reviewed I
just went ahead and pushed the remaining sim changes. (figuring no one would be
too miffed)
Hope all is ok now.
-Stafford
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-06-13 12:29 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-13 12:05 Recent changes broke the or1k simulator support Sebastian Huber
2019-06-13 12:19 ` Stafford Horne
2019-06-13 12:24 ` Sebastian Huber
2019-06-13 12:29 ` Stafford Horne
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox