From: Stafford Horne <shorne@gmail.com>
To: Andrew Burgess <andrew.burgess@embecosm.com>
Cc: GDB patches <gdb-patches@sourceware.org>,
GNU Binutils <binutils@sourceware.org>,
Andrey Bacherov <bandvig@mail.ru>,
Nick Clifton <nickc@redhat.com>,
Richard Henderson <rth@twiddle.net>,
Openrisc <openrisc@lists.librecores.org>
Subject: Re: [PATCH v3 10/11] sim/testsuite/or1k: Add test case for l.adrp instruction
Date: Wed, 12 Jun 2019 13:09:00 -0000 [thread overview]
Message-ID: <20190612130932.GB2358@lianli.shorne-pla.net> (raw)
In-Reply-To: <20190611214811.GS23204@embecosm.com>
On Tue, Jun 11, 2019 at 10:48:11PM +0100, Andrew Burgess wrote:
> * Stafford Horne <shorne@gmail.com> [2019-06-11 05:49:39 +0900]:
>
> > This is a simple test to ensure that the l.adrp instruction can be assembled and
> > simulated correctly.
> >
> > sim/testsuite/sim/or1k/ChangeLog:
> >
> > yyyy-mm-dd Stafford Horne <shorne@gmail.com>
> >
> > * adrp.S: New file.
>
> This is fine with one nit below.
>
> Thanks,
> Andrew
>
>
> > ---
> > Changes since v2:
> > - new patch
> >
> > sim/testsuite/sim/or1k/adrp.S | 73 +++++++++++++++++++++++++++++++++++
> > 1 file changed, 73 insertions(+)
> > create mode 100644 sim/testsuite/sim/or1k/adrp.S
> >
> > diff --git a/sim/testsuite/sim/or1k/adrp.S b/sim/testsuite/sim/or1k/adrp.S
> > new file mode 100644
> > index 0000000000..ba384ccc84
> > --- /dev/null
> > +++ b/sim/testsuite/sim/or1k/adrp.S
> > @@ -0,0 +1,73 @@
> > +/* Tests the load page address instruction.
> > +
> > + Copyright (C) 2017-2019 Free Software Foundation, Inc.
>
> This date range should just be '2019'.
Oh, of course, bad copy from me.
-Stafford
prev parent reply other threads:[~2019-06-12 13:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-10 20:49 Stafford Horne
2019-06-10 20:49 ` [PATCH v3 11/11] sim/testsuite/or1k: Add tests for unordered compares Stafford Horne
2019-06-11 21:49 ` Andrew Burgess
2019-06-12 13:11 ` Stafford Horne
2019-06-11 21:48 ` [PATCH v3 10/11] sim/testsuite/or1k: Add test case for l.adrp instruction Andrew Burgess
2019-06-12 13:09 ` Stafford Horne [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190612130932.GB2358@lianli.shorne-pla.net \
--to=shorne@gmail.com \
--cc=andrew.burgess@embecosm.com \
--cc=bandvig@mail.ru \
--cc=binutils@sourceware.org \
--cc=gdb-patches@sourceware.org \
--cc=nickc@redhat.com \
--cc=openrisc@lists.librecores.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox