From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16519 invoked by alias); 12 Jun 2019 13:09:39 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 15830 invoked by uid 89); 12 Jun 2019 13:09:38 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-24.8 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy=HX-Received:ed0a, HX-Spam-Relays-External:209.85.215.193, H*RU:209.85.215.193, H*r:sk:mail-pg X-HELO: mail-pg1-f193.google.com Received: from mail-pg1-f193.google.com (HELO mail-pg1-f193.google.com) (209.85.215.193) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 12 Jun 2019 13:09:37 +0000 Received: by mail-pg1-f193.google.com with SMTP id f21so2898781pgi.3; Wed, 12 Jun 2019 06:09:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=YKrXb0FImMFr8ECNDcQaG78GecrM5BuAIZ2zbC5Bqo4=; b=V3oTr+rBMV2UgckMboS0X30lfi88pk/5qJy1MCwLGwNYnt4m2vCigCAf8lUqw1mONa +kE+OGqbD0hTOQ1P1apcrmvnCNlnuIZj2PntdctWSfivcRab4affz5D4l0o0ZniO1fp7 +V9u1Stq59pq91U+pSA1BBspyB32oWdML5RFDaQK6Ka/aP0YY3s46tPuhXa0e50eLQy2 rH7X54LW+QQiLJ1DfXxxPSGikIUyS+altMRtSSh1GstFefA49tyapl41SBfE4pnUHuG0 DTaON0fDpRO81/Owhkt4rfL/5KCOBMlD3zi2JnLrXpY1NYR8lCZgrCDEf4s5vcuMbo9z p0FQ== Return-Path: Received: from localhost (g30.211-19-85.ppp.wakwak.ne.jp. [211.19.85.30]) by smtp.gmail.com with ESMTPSA id b17sm21728469pfb.18.2019.06.12.06.09.34 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Wed, 12 Jun 2019 06:09:34 -0700 (PDT) Date: Wed, 12 Jun 2019 13:09:00 -0000 From: Stafford Horne To: Andrew Burgess Cc: GDB patches , GNU Binutils , Andrey Bacherov , Nick Clifton , Richard Henderson , Openrisc Subject: Re: [PATCH v3 10/11] sim/testsuite/or1k: Add test case for l.adrp instruction Message-ID: <20190612130932.GB2358@lianli.shorne-pla.net> References: <20190610204940.3846-1-shorne@gmail.com> <20190611214811.GS23204@embecosm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190611214811.GS23204@embecosm.com> User-Agent: Mutt/1.11.4 (2019-03-13) X-IsSubscribed: yes X-SW-Source: 2019-06/txt/msg00227.txt.bz2 On Tue, Jun 11, 2019 at 10:48:11PM +0100, Andrew Burgess wrote: > * Stafford Horne [2019-06-11 05:49:39 +0900]: > > > This is a simple test to ensure that the l.adrp instruction can be assembled and > > simulated correctly. > > > > sim/testsuite/sim/or1k/ChangeLog: > > > > yyyy-mm-dd Stafford Horne > > > > * adrp.S: New file. > > This is fine with one nit below. > > Thanks, > Andrew > > > > --- > > Changes since v2: > > - new patch > > > > sim/testsuite/sim/or1k/adrp.S | 73 +++++++++++++++++++++++++++++++++++ > > 1 file changed, 73 insertions(+) > > create mode 100644 sim/testsuite/sim/or1k/adrp.S > > > > diff --git a/sim/testsuite/sim/or1k/adrp.S b/sim/testsuite/sim/or1k/adrp.S > > new file mode 100644 > > index 0000000000..ba384ccc84 > > --- /dev/null > > +++ b/sim/testsuite/sim/or1k/adrp.S > > @@ -0,0 +1,73 @@ > > +/* Tests the load page address instruction. > > + > > + Copyright (C) 2017-2019 Free Software Foundation, Inc. > > This date range should just be '2019'. Oh, of course, bad copy from me. -Stafford