From: Andrew Burgess <andrew.burgess@embecosm.com>
To: Tom Tromey <tromey@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Add "set print finish"
Date: Thu, 16 May 2019 21:46:00 -0000 [thread overview]
Message-ID: <20190516214646.GU2568@embecosm.com> (raw)
In-Reply-To: <87lfz6w9ug.fsf@tromey.com>
* Tom Tromey <tromey@adacore.com> [2019-05-16 12:08:39 -0600]:
> >>>>> "Andrew" == Andrew Burgess <andrew.burgess@embecosm.com> writes:
>
> >> + add_setshow_boolean_cmd ("finish", class_support,
> >> + &user_print_options.finish_print, _("\
> >> +Set whether `finish' prints the return value."), _("\
> >> +Show whether `finish' prints the return value."), NULL,
> >> + NULL,
> >> + show_print_finish,
> >> + &setprintlist, &showprintlist);
>
>
> >> + /* Whether "finish" should print the value. */
> >> + int finish_print;
> >> };
>
> Andrew> Should new flags not be bool ?
>
> Ordinarily, but in this case the address of one of these is passed to
> add_setshow_boolean_cmd, which still takes an "int *" -- see the code I
> quoted above.
Of course. Sorry for the noise :)
Thanks,
Andrew
>
> Tom
next prev parent reply other threads:[~2019-05-16 21:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-16 16:32 Tom Tromey
2019-05-16 17:29 ` Eli Zaretskii
2019-05-16 17:52 ` Andrew Burgess
2019-05-16 18:08 ` Tom Tromey
2019-05-16 21:46 ` Andrew Burgess [this message]
2019-05-29 14:26 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190516214646.GU2568@embecosm.com \
--to=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox