From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29128 invoked by alias); 16 May 2019 21:46:51 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 29120 invoked by uid 89); 16 May 2019 21:46:51 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-14.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy=HX-Languages-Length:836 X-HELO: mail-wm1-f48.google.com Received: from mail-wm1-f48.google.com (HELO mail-wm1-f48.google.com) (209.85.128.48) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 16 May 2019 21:46:50 +0000 Received: by mail-wm1-f48.google.com with SMTP id c77so3558456wmd.1 for ; Thu, 16 May 2019 14:46:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=wplExW6PnyS0asft5NXXBSnBqHitrWkusPbUcpy2ghg=; b=Of/bz5AuolaGb4m501raKHIzE+XujOGi4TDZOBmertKGZVNZaQCWgrPKArITv2FDTH VJcwMfQO+B+gb/B1ROq6rt8Wfzy0+j80uHSO/2eC7G9ILKETp8bSafdtVaGwvk0HN42f 5Qk+aw8+rRg/tU32Mq2GxYPx0izXKP2cQ0Il6tOWc/dEf7QhT0azt3RxMhDPdExcvB0J hFuOg10rgyP8nvGu/PCTjIjGMgLKiWOgpBVXFeYoN2EzZK5EWB2pY/OpeuiFGrj4C1Xv NE5iE/pL+m5SFNMoZFD2BKSMieO+Wsu5KsAHkDEyuDigQ940KzNn81+KQgXr7CcwN2y5 H1JA== Return-Path: Received: from localhost (host86-180-62-212.range86-180.btcentralplus.com. [86.180.62.212]) by smtp.gmail.com with ESMTPSA id a184sm7221606wmh.36.2019.05.16.14.46.47 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 16 May 2019 14:46:47 -0700 (PDT) Date: Thu, 16 May 2019 21:46:00 -0000 From: Andrew Burgess To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Add "set print finish" Message-ID: <20190516214646.GU2568@embecosm.com> References: <20190516163244.20180-1-tromey@adacore.com> <20190516175246.GR2568@embecosm.com> <87lfz6w9ug.fsf@tromey.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87lfz6w9ug.fsf@tromey.com> X-Fortune: You can't judge a book by the way it wears its hair. X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] User-Agent: Mutt/1.9.2 (2017-12-15) X-IsSubscribed: yes X-SW-Source: 2019-05/txt/msg00405.txt.bz2 * Tom Tromey [2019-05-16 12:08:39 -0600]: > >>>>> "Andrew" == Andrew Burgess writes: > > >> + add_setshow_boolean_cmd ("finish", class_support, > >> + &user_print_options.finish_print, _("\ > >> +Set whether `finish' prints the return value."), _("\ > >> +Show whether `finish' prints the return value."), NULL, > >> + NULL, > >> + show_print_finish, > >> + &setprintlist, &showprintlist); > > > >> + /* Whether "finish" should print the value. */ > >> + int finish_print; > >> }; > > Andrew> Should new flags not be bool ? > > Ordinarily, but in this case the address of one of these is passed to > add_setshow_boolean_cmd, which still takes an "int *" -- see the code I > quoted above. Of course. Sorry for the noise :) Thanks, Andrew > > Tom