From: Kevin Buettner <kevinb@redhat.com>
To: gdb-patches@sourceware.org
Cc: Andrew Burgess <andrew.burgess@embecosm.com>
Subject: Re: [PATCH 3/3] gdb/nds32: Use type_align instead of nds32_type_align
Date: Sun, 14 Apr 2019 18:53:00 -0000 [thread overview]
Message-ID: <20190414115352.4a3cb8a2@f29-4.lan> (raw)
In-Reply-To: <6e5973aace6c35e5edfd75ce7b268f44b7bd42a2.1555111225.git.andrew.burgess@embecosm.com>
On Sat, 13 Apr 2019 00:25:34 +0100
Andrew Burgess <andrew.burgess@embecosm.com> wrote:
> The general type_align method should be a suitable alternative to
> nds32_type_align, so switch to use that.
>
> The only change this will introduce is related to static fields in a
> struct or union, the existing code doesn't take account of static
> fields when computing the alignment for structs of unions, though this
> is probably a bug - which would probably be exposed by the test case
> gdb.cp/many-args.exp, though I don't have any way to test this target
> right now.
>
> gdb/ChangeLog:
>
> * nds32-tdep.c (nds32_type_align): Delete.
> (nds32_push_dummy_call): Use type_align instead.
I think that nds32_type_align needs to be registered in
nds32_gdbarch_init().
Otherwise, LGTM.
Kevin
next prev parent reply other threads:[~2019-04-14 18:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-12 23:25 [PATCH 0/3] More use of type_align function Andrew Burgess
2019-04-12 23:25 ` [PATCH 2/3] gdb/arm: Use type_align instead of arm_type_align Andrew Burgess
2019-04-14 18:56 ` Kevin Buettner
2019-04-12 23:25 ` [PATCH 3/3] gdb/nds32: Use type_align instead of nds32_type_align Andrew Burgess
2019-04-14 18:53 ` Kevin Buettner [this message]
2019-04-17 20:59 ` Andrew Burgess
2019-04-18 0:02 ` Kevin Buettner
2019-04-12 23:25 ` [PATCH 1/3] gdb/aarch64: Use type_align instead of aarch64_type_align Andrew Burgess
2019-04-14 18:54 ` Kevin Buettner
2019-04-23 21:08 ` [PATCH 0/3] More use of type_align function Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190414115352.4a3cb8a2@f29-4.lan \
--to=kevinb@redhat.com \
--cc=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox