From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 71173 invoked by alias); 14 Apr 2019 18:53:56 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 71154 invoked by uid 89); 14 Apr 2019 18:53:55 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.9 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 14 Apr 2019 18:53:54 +0000 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 2ACE8308212A; Sun, 14 Apr 2019 18:53:53 +0000 (UTC) Received: from f29-4.lan (ovpn-116-111.phx2.redhat.com [10.3.116.111]) by smtp.corp.redhat.com (Postfix) with ESMTPS id F3299600C8; Sun, 14 Apr 2019 18:53:52 +0000 (UTC) Date: Sun, 14 Apr 2019 18:53:00 -0000 From: Kevin Buettner To: gdb-patches@sourceware.org Cc: Andrew Burgess Subject: Re: [PATCH 3/3] gdb/nds32: Use type_align instead of nds32_type_align Message-ID: <20190414115352.4a3cb8a2@f29-4.lan> In-Reply-To: <6e5973aace6c35e5edfd75ce7b268f44b7bd42a2.1555111225.git.andrew.burgess@embecosm.com> References: <6e5973aace6c35e5edfd75ce7b268f44b7bd42a2.1555111225.git.andrew.burgess@embecosm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2019-04/txt/msg00256.txt.bz2 On Sat, 13 Apr 2019 00:25:34 +0100 Andrew Burgess wrote: > The general type_align method should be a suitable alternative to > nds32_type_align, so switch to use that. > > The only change this will introduce is related to static fields in a > struct or union, the existing code doesn't take account of static > fields when computing the alignment for structs of unions, though this > is probably a bug - which would probably be exposed by the test case > gdb.cp/many-args.exp, though I don't have any way to test this target > right now. > > gdb/ChangeLog: > > * nds32-tdep.c (nds32_type_align): Delete. > (nds32_push_dummy_call): Use type_align instead. I think that nds32_type_align needs to be registered in nds32_gdbarch_init(). Otherwise, LGTM. Kevin