From: "Ulrich Weigand" <uweigand@de.ibm.com>
To: pedromfc@linux.ibm.com (Pedro Franco de Carvalho)
Cc: Alan.Hayward@arm.com (Alan Hayward),
simark@simark.ca (Simon Marchi),
gdb-patches@sourceware.org (gdb-patches\@sourceware.org),
nd@arm.com (nd)
Subject: Re: [PATCH 2/2] gdbserver: Add linux_get_hwcap
Date: Thu, 04 Apr 2019 13:49:00 -0000 [thread overview]
Message-ID: <20190404134915.95BF1D802CA@oc3748833570.ibm.com> (raw)
In-Reply-To: <875zruhph3.fsf@linux.vnet.ibm.com> from "Pedro Franco de Carvalho" at Apr 03, 2019 04:13:12 PM
Pedro Franco de Carvalho wrote:
> I noticed that is_elfv2_inferior previously relied on ppc_get_auxv
> returning whether or not the AT_PHDR key is found, besides the vector
> value. The actual value was returned in the pointer argument. The new
> linux_get_auxv returns 0 for the value if the key isn't found. I don't
> know if the value for AT_PHDR can be an actual 0.
Seems unlikely, but I guess theoretically possible on some platforms.
But in general, there is a difference between an AT_ aux vector entry
not present, or present with value zero, so the interface should be
able to represent that.
> Should linux_get_auxv be changed to return this and also take a
> CORE_ADDR pointer? It should also be made visible in the header.
Sounds reasonable to me.
Bye,
Ulrich
--
Dr. Ulrich Weigand
GNU/Linux compilers and toolchain
Ulrich.Weigand@de.ibm.com
next prev parent reply other threads:[~2019-04-04 13:49 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-25 12:05 [PATCH 1/2] " Alan Hayward
2019-03-25 12:05 ` [PATCH 2/2] gdbserver: " Alan Hayward
2019-03-25 15:41 ` Simon Marchi
2019-03-26 13:17 ` Alan Hayward
[not found] ` <353e83d9-efb3-c485-9ae6-6fc0a1f54553@simark.ca>
[not found] ` <57CEBD0C-44A5-48D1-8CEB-54584E1A1A21@arm.com>
[not found] ` <59A457A2-F464-4A05-A471-700F066114AD@arm.com>
2019-03-26 14:34 ` FW: " Alan Hayward
2019-03-28 9:50 ` Ulrich Weigand
2019-03-28 11:35 ` Alan Hayward
2019-03-29 23:12 ` Ulrich Weigand
2019-04-03 19:13 ` Pedro Franco de Carvalho
2019-04-04 13:49 ` Ulrich Weigand [this message]
2019-04-05 16:26 ` Pedro Franco de Carvalho
2019-04-05 16:39 ` Ulrich Weigand
2019-04-05 17:23 ` Pedro Franco de Carvalho
2019-04-08 9:38 ` Alan Hayward
2019-04-11 14:12 ` Pedro Franco de Carvalho
2019-03-26 14:56 ` FW: " Simon Marchi
2019-04-02 22:00 ` Peter Bergner
2019-04-04 21:22 ` Pedro Franco de Carvalho
2019-03-25 15:18 ` [PATCH 1/2] " Simon Marchi
2019-03-25 16:51 ` Alan Hayward
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190404134915.95BF1D802CA@oc3748833570.ibm.com \
--to=uweigand@de.ibm.com \
--cc=Alan.Hayward@arm.com \
--cc=gdb-patches@sourceware.org \
--cc=nd@arm.com \
--cc=pedromfc@linux.ibm.com \
--cc=simark@simark.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox