From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 52644 invoked by alias); 4 Apr 2019 13:49:25 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 52632 invoked by uid 89); 4 Apr 2019 13:49:24 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00,KHOP_DYNAMIC,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=no version=3.3.1 spammy=aux, noticed X-HELO: mx0a-001b2d01.pphosted.com Received: from mx0b-001b2d01.pphosted.com (HELO mx0a-001b2d01.pphosted.com) (148.163.158.5) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 04 Apr 2019 13:49:23 +0000 Received: from pps.filterd (m0098419.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x34DWR0l119559 for ; Thu, 4 Apr 2019 09:49:22 -0400 Received: from e06smtp01.uk.ibm.com (e06smtp01.uk.ibm.com [195.75.94.97]) by mx0b-001b2d01.pphosted.com with ESMTP id 2rnjrescsv-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 04 Apr 2019 09:49:21 -0400 Received: from localhost by e06smtp01.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 4 Apr 2019 14:49:20 +0100 Received: from b06cxnps4076.portsmouth.uk.ibm.com (9.149.109.198) by e06smtp01.uk.ibm.com (192.168.101.131) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Thu, 4 Apr 2019 14:49:17 +0100 Received: from d06av23.portsmouth.uk.ibm.com (d06av23.portsmouth.uk.ibm.com [9.149.105.59]) by b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x34DnGFi50528422 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 4 Apr 2019 13:49:16 GMT Received: from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E8758A4055; Thu, 4 Apr 2019 13:49:15 +0000 (GMT) Received: from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id D419AA4057; Thu, 4 Apr 2019 13:49:15 +0000 (GMT) Received: from oc3748833570.ibm.com (unknown [9.152.214.226]) by d06av23.portsmouth.uk.ibm.com (Postfix) with ESMTP; Thu, 4 Apr 2019 13:49:15 +0000 (GMT) Received: by oc3748833570.ibm.com (Postfix, from userid 1000) id 95BF1D802CA; Thu, 4 Apr 2019 15:49:15 +0200 (CEST) Subject: Re: [PATCH 2/2] gdbserver: Add linux_get_hwcap To: pedromfc@linux.ibm.com (Pedro Franco de Carvalho) Date: Thu, 04 Apr 2019 13:49:00 -0000 From: "Ulrich Weigand" Cc: Alan.Hayward@arm.com (Alan Hayward), simark@simark.ca (Simon Marchi), gdb-patches@sourceware.org (gdb-patches\@sourceware.org), nd@arm.com (nd) In-Reply-To: <875zruhph3.fsf@linux.vnet.ibm.com> from "Pedro Franco de Carvalho" at Apr 03, 2019 04:13:12 PM MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit x-cbid: 19040413-4275-0000-0000-0000032442BE X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19040413-4276-0000-0000-000038334EA1 Message-Id: <20190404134915.95BF1D802CA@oc3748833570.ibm.com> X-SW-Source: 2019-04/txt/msg00069.txt.bz2 Pedro Franco de Carvalho wrote: > I noticed that is_elfv2_inferior previously relied on ppc_get_auxv > returning whether or not the AT_PHDR key is found, besides the vector > value. The actual value was returned in the pointer argument. The new > linux_get_auxv returns 0 for the value if the key isn't found. I don't > know if the value for AT_PHDR can be an actual 0. Seems unlikely, but I guess theoretically possible on some platforms. But in general, there is a difference between an AT_ aux vector entry not present, or present with value zero, so the interface should be able to represent that. > Should linux_get_auxv be changed to return this and also take a > CORE_ADDR pointer? It should also be made visible in the header. Sounds reasonable to me. Bye, Ulrich -- Dr. Ulrich Weigand GNU/Linux compilers and toolchain Ulrich.Weigand@de.ibm.com