Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: John Darrington <john@darrington.wattle.id.au>
To: gdb-patches@sourceware.org
Cc: tromey@adacore.com
Subject: Commit "Introduce ATTRIBUTE_UNUSED_RESULT and use it" breaks gdb build
Date: Wed, 06 Mar 2019 07:49:00 -0000	[thread overview]
Message-ID: <20190306074924.lmwwwvk3ywpjkcfw@jocasta.intra> (raw)

This change:

commit 18cb7c9f3add62ff598f0551a767af8aaa04b07e
Author: Tom Tromey <tromey@adacore.com>
Date:   Tue Feb 26 14:39:01 2019 -0700

    Introduce ATTRIBUTE_UNUSED_RESULT and use it

    This introduces the new ATTRIBUTE_UNUSED_RESULT define, and applies it
        to gdb_argv::release.


Seems to cause gdb to not compile, when built with default flags.

CXX    remote-sim.o
/home/john/binutils-gdb/gdb/remote-sim.c: In function 'void gdbsim_target_open(const char*, int)':
/home/john/binutils-gdb/gdb/remote-sim.c:765:18: error: ignoring return value of 'char** gdb_argv::release()', declared with attribute warn_unused_result [-Werror=unused-result]
    argv.release ();
                   ^

cc1plus: all warnings being treated as errors
Makefile:1637: recipe for target 'remote-sim.o' failed

J'
		      


             reply	other threads:[~2019-03-06  7:49 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-06  7:49 John Darrington [this message]
2019-03-06 14:58 ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190306074924.lmwwwvk3ywpjkcfw@jocasta.intra \
    --to=john@darrington.wattle.id.au \
    --cc=gdb-patches@sourceware.org \
    --cc=tromey@adacore.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox