From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-154393-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 121024 invoked by alias); 6 Mar 2019 07:49:34 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 121003 invoked by uid 89); 6 Mar 2019 07:49:34 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy=H*F:U*john
X-HELO: jocasta.intra
Received: from de.cellform.com (HELO jocasta.intra) (88.217.224.109) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 06 Mar 2019 07:49:30 +0000
Received: from jocasta.intra (localhost [127.0.0.1])	by jocasta.intra (8.15.2/8.15.2/Debian-8) with ESMTPS id x267nPK2016651	(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);	Wed, 6 Mar 2019 08:49:25 +0100
Received: (from john@localhost)	by jocasta.intra (8.15.2/8.15.2/Submit) id x267nOK7016650;	Wed, 6 Mar 2019 08:49:24 +0100
Date: Wed, 06 Mar 2019 07:49:00 -0000
From: John Darrington <john@darrington.wattle.id.au>
To: gdb-patches@sourceware.org
Cc: tromey@adacore.com
Subject: Commit "Introduce ATTRIBUTE_UNUSED_RESULT and use it" breaks gdb build
Message-ID: <20190306074924.lmwwwvk3ywpjkcfw@jocasta.intra>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: NeoMutt/20170113 (1.7.2)
X-SW-Source: 2019-03/txt/msg00081.txt.bz2

This change:

commit 18cb7c9f3add62ff598f0551a767af8aaa04b07e
Author: Tom Tromey <tromey@adacore.com>
Date:   Tue Feb 26 14:39:01 2019 -0700

    Introduce ATTRIBUTE_UNUSED_RESULT and use it

    This introduces the new ATTRIBUTE_UNUSED_RESULT define, and applies it
        to gdb_argv::release.


Seems to cause gdb to not compile, when built with default flags.

CXX    remote-sim.o
/home/john/binutils-gdb/gdb/remote-sim.c: In function 'void gdbsim_target_open(const char*, int)':
/home/john/binutils-gdb/gdb/remote-sim.c:765:18: error: ignoring return value of 'char** gdb_argv::release()', declared with attribute warn_unused_result [-Werror=unused-result]
    argv.release ();
                   ^

cc1plus: all warnings being treated as errors
Makefile:1637: recipe for target 'remote-sim.o' failed

J'