From: Kevin Buettner <kevinb@redhat.com>
To: gdb-patches@sourceware.org
Cc: Tom Tromey <tromey@adacore.com>
Subject: Re: [PATCH 1/2] Change iterate_over_lwps to take a gdb::function_view
Date: Mon, 04 Mar 2019 23:28:00 -0000 [thread overview]
Message-ID: <20190304162850.6ad26d25@f29-4.lan> (raw)
In-Reply-To: <20190304202516.19100-2-tromey@adacore.com>
On Mon, 4 Mar 2019 13:25:15 -0700
Tom Tromey <tromey@adacore.com> wrote:
> This changes iterate_over_lwps to use a gdb::function_view. This was
> needed in order to make null_ptid and minus_one_ptid 'const'.
>
> gdb/ChangeLog
> 2019-03-04 Tom Tromey <tromey@adacore.com>
>
> * linux-nat.c (iterate_over_lwps): Update.
> (stop_callback): Remove parameter.
> (stop_wait_callback, detach_callback, resume_set_callback)
> (select_singlestep_lwp_callback, set_ignore_sigint)
> (status_callback, resumed_callback, resume_clear_callback)
> (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
> data parameter.
> (linux_nat_target::detach, linux_nat_target::resume)
> (linux_stop_and_wait_all_lwps, select_event_lwp)
> (linux_nat_filter_event, linux_nat_wait_1)
> (linux_nat_target::kill, linux_nat_target::stop)
> (linux_nat_target::stop): Update.
> (linux_nat_resume_callback): Change type.
> (resume_stopped_resumed_lwps, count_events_callback)
> (select_event_lwp_callback): Likewise.
> (linux_stop_lwp, linux_nat_stop_lwp): Update.
> * arm-linux-nat.c (struct update_registers_data): Remove.
> (update_registers_callback): Change type.
> (arm_linux_insert_hw_breakpoint1): Update.
> * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
> parameter.
> (x86_linux_dr_set_addr): Update.
> (x86_linux_dr_set_control): Update.
> * nat/linux-nat.h (iterate_over_lwps_ftype): Remove user-data
> parameter.
> (iterate_over_lwps): Use gdb::function_view.
> * nat/aarch64-linux-hw-point.c (struct
> aarch64_dr_update_callback_param): Remove.
> (debug_reg_change_callback): Change type.
> (aarch64_notify_debug_reg_change): Update.
> * s390-linux-nat.c (s390_refresh_per_info): Update.
>
> gdb/gdbserver/ChangeLog
> 2019-03-04 Tom Tromey <tromey@adacore.com>
>
> * linux-low.c (iterate_over_lwps): Update.
I read through the patch. LGTM.
The only nit I have regarding the ChangeLog entry is with "Remove
user-data parameter." I think it'd be fine to just say "Remove
data parameter." Not a big deal to me though.
Kevin
next prev parent reply other threads:[~2019-03-04 23:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-04 20:25 [PATCH 0/2] constify null_ptid and minus_one_ptid Tom Tromey
2019-03-04 20:25 ` [PATCH 1/2] Change iterate_over_lwps to take a gdb::function_view Tom Tromey
2019-03-04 23:28 ` Kevin Buettner [this message]
2019-03-04 20:25 ` [PATCH 2/2] Make null_ptid and minus_one_ptid "const" Tom Tromey
2019-03-04 23:30 ` Kevin Buettner
2019-03-12 16:46 ` [PATCH 0/2] constify null_ptid and minus_one_ptid Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190304162850.6ad26d25@f29-4.lan \
--to=kevinb@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox