From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 126123 invoked by alias); 4 Mar 2019 23:28:54 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 126111 invoked by uid 89); 4 Mar 2019 23:28:54 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=H*M:lan, H*MI:sk:2019030 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 04 Mar 2019 23:28:52 +0000 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 86D8F307D924; Mon, 4 Mar 2019 23:28:51 +0000 (UTC) Received: from f29-4.lan (ovpn-117-11.phx2.redhat.com [10.3.117.11]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3DF9A60139; Mon, 4 Mar 2019 23:28:51 +0000 (UTC) Date: Mon, 04 Mar 2019 23:28:00 -0000 From: Kevin Buettner To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: Re: [PATCH 1/2] Change iterate_over_lwps to take a gdb::function_view Message-ID: <20190304162850.6ad26d25@f29-4.lan> In-Reply-To: <20190304202516.19100-2-tromey@adacore.com> References: <20190304202516.19100-1-tromey@adacore.com> <20190304202516.19100-2-tromey@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2019-03/txt/msg00048.txt.bz2 On Mon, 4 Mar 2019 13:25:15 -0700 Tom Tromey wrote: > This changes iterate_over_lwps to use a gdb::function_view. This was > needed in order to make null_ptid and minus_one_ptid 'const'. > > gdb/ChangeLog > 2019-03-04 Tom Tromey > > * linux-nat.c (iterate_over_lwps): Update. > (stop_callback): Remove parameter. > (stop_wait_callback, detach_callback, resume_set_callback) > (select_singlestep_lwp_callback, set_ignore_sigint) > (status_callback, resumed_callback, resume_clear_callback) > (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove > data parameter. > (linux_nat_target::detach, linux_nat_target::resume) > (linux_stop_and_wait_all_lwps, select_event_lwp) > (linux_nat_filter_event, linux_nat_wait_1) > (linux_nat_target::kill, linux_nat_target::stop) > (linux_nat_target::stop): Update. > (linux_nat_resume_callback): Change type. > (resume_stopped_resumed_lwps, count_events_callback) > (select_event_lwp_callback): Likewise. > (linux_stop_lwp, linux_nat_stop_lwp): Update. > * arm-linux-nat.c (struct update_registers_data): Remove. > (update_registers_callback): Change type. > (arm_linux_insert_hw_breakpoint1): Update. > * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove > parameter. > (x86_linux_dr_set_addr): Update. > (x86_linux_dr_set_control): Update. > * nat/linux-nat.h (iterate_over_lwps_ftype): Remove user-data > parameter. > (iterate_over_lwps): Use gdb::function_view. > * nat/aarch64-linux-hw-point.c (struct > aarch64_dr_update_callback_param): Remove. > (debug_reg_change_callback): Change type. > (aarch64_notify_debug_reg_change): Update. > * s390-linux-nat.c (s390_refresh_per_info): Update. > > gdb/gdbserver/ChangeLog > 2019-03-04 Tom Tromey > > * linux-low.c (iterate_over_lwps): Update. I read through the patch. LGTM. The only nit I have regarding the ChangeLog entry is with "Remove user-data parameter." I think it'd be fine to just say "Remove data parameter." Not a big deal to me though. Kevin