From: Andrew Burgess <andrew.burgess@embecosm.com>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb: Don't flush line wrap buffer before adding newline
Date: Tue, 05 Feb 2019 17:15:00 -0000 [thread overview]
Message-ID: <20190205171516.GD2829@embecosm.com> (raw)
In-Reply-To: <87pns6nrjr.fsf@tromey.com>
* Tom Tromey <tom@tromey.com> [2019-02-05 09:11:52 -0700]:
> >>>>> "Andrew" == Andrew Burgess <andrew.burgess@embecosm.com> writes:
>
> Andrew> The patch below shows a new proposal for utils.c.
> Andrew> Do you agree with the issues I see above?
> Andrew> What do you think of the new approach?
>
> Could you try my branch? It fixes this problem and a few more
> besides.
Yes, this fixes the original issue, and a second issue that I had an
almost complete patch for.
I'll wait for your fixes to land.
Thanks,
Andrew
> I am in the process -- kind of slow due to travel etc -- of writing the
> last couple of test cases to make sure it is all correct... Philippe
> found a number of bugs in this area a while back and the branch attempts
> to fix them all.
>
> It's the branch submit/fix-pager on my github.
> It's in an ugly form right now (I didn't squash the patches yet), but
> that shouldn't matter for trying it.
>
> Tom
prev parent reply other threads:[~2019-02-05 17:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-05 15:10 Andrew Burgess
2019-02-05 15:27 ` Tom Tromey
2019-02-05 15:55 ` Andrew Burgess
2019-02-05 20:44 ` Tom Tromey
2019-02-05 17:15 ` Andrew Burgess [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190205171516.GD2829@embecosm.com \
--to=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox