From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 101974 invoked by alias); 5 Feb 2019 17:15:47 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 97313 invoked by uid 89); 5 Feb 2019 17:15:26 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=travel X-HELO: mail-wm1-f65.google.com Received: from mail-wm1-f65.google.com (HELO mail-wm1-f65.google.com) (209.85.128.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 05 Feb 2019 17:15:25 +0000 Received: by mail-wm1-f65.google.com with SMTP id z5so4479868wmf.0 for ; Tue, 05 Feb 2019 09:15:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=yjhR0xouK+NBPKaMcXfv0hvhHL9/yqspSM8OSE2hlHk=; b=Y+WCmeIPtq8NRLOlorVsXsZsSML1ULq/8+Zx/DX4UQ4RtO/lYuHtDffAGyKKsN5og/ 8y/uo+yN15Q1bVwzD1C/VuaJYDIdZL750LdRc3nOMcs4QlnyVGYX18Z7AkVNF6Fcc92v PnErFCEzErSbzUBGUgstwIVwQVYBiKmLevVJ4bAPDPFNSHKbLfYrGIIii3PPxk1NtWRR a8Qo4ZUkCgfmcw7+Eek/IO8ZeS4lichntTZ2+pP3OCeK/A/KSDneFvGuQLwkMeeGQ/HY tISwUTWa0ZlReiRlNF9IaM+kX69nKNV5cBXaHMghvnE/BPSPDGOUWkzuVeIUGaVE7CUi F4Cw== Return-Path: Received: from localhost (cust64-dsl91-135-5.idnet.net. [91.135.5.64]) by smtp.gmail.com with ESMTPSA id r200sm30244089wmb.36.2019.02.05.09.15.17 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 05 Feb 2019 09:15:17 -0800 (PST) Date: Tue, 05 Feb 2019 17:15:00 -0000 From: Andrew Burgess To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] gdb: Don't flush line wrap buffer before adding newline Message-ID: <20190205171516.GD2829@embecosm.com> References: <20190205151016.2127-1-andrew.burgess@embecosm.com> <87womentlq.fsf@tromey.com> <20190205155545.GC2829@embecosm.com> <87pns6nrjr.fsf@tromey.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87pns6nrjr.fsf@tromey.com> X-Fortune: The vulcan-death-grip ping has been applied. X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] User-Agent: Mutt/1.9.2 (2017-12-15) X-IsSubscribed: yes X-SW-Source: 2019-02/txt/msg00025.txt.bz2 * Tom Tromey [2019-02-05 09:11:52 -0700]: > >>>>> "Andrew" == Andrew Burgess writes: > > Andrew> The patch below shows a new proposal for utils.c. > Andrew> Do you agree with the issues I see above? > Andrew> What do you think of the new approach? > > Could you try my branch? It fixes this problem and a few more > besides. Yes, this fixes the original issue, and a second issue that I had an almost complete patch for. I'll wait for your fixes to land. Thanks, Andrew > I am in the process -- kind of slow due to travel etc -- of writing the > last couple of test cases to make sure it is all correct... Philippe > found a number of bugs in this area a while back and the branch attempts > to fix them all. > > It's the branch submit/fix-pager on my github. > It's in an ugly form right now (I didn't squash the patches yet), but > that shouldn't matter for trying it. > > Tom