From: Joel Brobecker <brobecker@adacore.com>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: GDB 8.3 release -- 2019-01-11 update
Date: Sun, 13 Jan 2019 05:22:00 -0000 [thread overview]
Message-ID: <20190113052153.GF22922@adacore.com> (raw)
In-Reply-To: <87sgxyojb3.fsf@tromey.com>
> Joel> * [TomT/Joel] <NO PR>
> Joel> GDB UI word wrapping broken/interferes with 'set style'
> Joel> https://www.sourceware.org/ml/gdb-patches/2018-12/msg00435.html
> Joel> https://www.sourceware.org/ml/gdb-patches/2019-01/msg00098.html
>
> I have a patch for this, I just need to write a test.
> Also I think I know what is up with the subsequent problems that
> Philippe reported.
Great! When you have something you'd like me to test, I'm quite happpy
to give it a try and report back.
> Joel> * [TomT] tui/20819
> Joel> Binding Control-j in inputrc breaks "layout asm"
> Joel> https://sourceware.org/bugzilla/show_bug.cgi?id=20819
> Joel> ... but i don't understand why this would be blocking for 8.3.
> Joel> It would be nice to have a way to get a more detailed history
> Joel> of the changes made to the status of that PR so we can determine
> Joel> when it was marked 8.3. My suspicion is that it was marked 8.3
> Joel> when fixed by Tom, and then the PR got re-opened (around Jan 2nd)
> Joel> due to a regression.
>
> Joel> Tom - do you confirm this is not a critical bug, other than
> Joel> maybe the regression, in which case it would be sufficient to
> Joel> simply revert?
>
> Reverting is certainly possible but perhaps it can be fixed some other
> way. The problem is that in "nonl" mode, RET in readline won't print a
> newline, leading to gdb output being on the same line as the input. I
> was thinking maybe the RET key binding, or maybe some other function in
> TUI, could print a newline when the input is accepted.
I see you just sent a patch. This is even better :). I suggested
the reverting only because you mentioned it in the PR.
--
Joel
prev parent reply other threads:[~2019-01-13 5:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-11 9:53 Joel Brobecker
2019-01-11 10:36 ` Eli Zaretskii
2019-01-11 13:41 ` Joel Brobecker
2019-01-11 16:10 ` Eli Zaretskii
2019-01-11 21:31 ` Philippe Waroquiers
2019-01-13 5:25 ` Joel Brobecker
[not found] ` <87sgxyojb3.fsf@tromey.com>
2019-01-13 5:22 ` Joel Brobecker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190113052153.GF22922@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox