From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 81448 invoked by alias); 13 Jan 2019 05:22:04 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 81433 invoked by uid 89); 13 Jan 2019 05:22:03 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1711, reverting X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 13 Jan 2019 05:22:01 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 786FB117872; Sun, 13 Jan 2019 00:22:00 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id bs8CSMkfXUmQ; Sun, 13 Jan 2019 00:22:00 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id E96D611786A; Sun, 13 Jan 2019 00:21:59 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id DFBF086749; Sun, 13 Jan 2019 09:21:53 +0400 (+04) Date: Sun, 13 Jan 2019 05:22:00 -0000 From: Joel Brobecker To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: GDB 8.3 release -- 2019-01-11 update Message-ID: <20190113052153.GF22922@adacore.com> References: <20190111095332.GB22922@adacore.com> <87sgxyojb3.fsf@tromey.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87sgxyojb3.fsf@tromey.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-SW-Source: 2019-01/txt/msg00307.txt.bz2 > Joel> * [TomT/Joel] > Joel> GDB UI word wrapping broken/interferes with 'set style' > Joel> https://www.sourceware.org/ml/gdb-patches/2018-12/msg00435.html > Joel> https://www.sourceware.org/ml/gdb-patches/2019-01/msg00098.html > > I have a patch for this, I just need to write a test. > Also I think I know what is up with the subsequent problems that > Philippe reported. Great! When you have something you'd like me to test, I'm quite happpy to give it a try and report back. > Joel> * [TomT] tui/20819 > Joel> Binding Control-j in inputrc breaks "layout asm" > Joel> https://sourceware.org/bugzilla/show_bug.cgi?id=20819 > Joel> ... but i don't understand why this would be blocking for 8.3. > Joel> It would be nice to have a way to get a more detailed history > Joel> of the changes made to the status of that PR so we can determine > Joel> when it was marked 8.3. My suspicion is that it was marked 8.3 > Joel> when fixed by Tom, and then the PR got re-opened (around Jan 2nd) > Joel> due to a regression. > > Joel> Tom - do you confirm this is not a critical bug, other than > Joel> maybe the regression, in which case it would be sufficient to > Joel> simply revert? > > Reverting is certainly possible but perhaps it can be fixed some other > way. The problem is that in "nonl" mode, RET in readline won't print a > newline, leading to gdb output being on the same line as the input. I > was thinking maybe the RET key binding, or maybe some other function in > TUI, could print a newline when the input is accepted. I see you just sent a patch. This is even better :). I suggested the reverting only because you mentioned it in the PR. -- Joel