From: Joel Brobecker <brobecker@adacore.com>
To: Simon Marchi <simon.marchi@polymtl.ca>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA/commit] GDB crash re-running program on Windows (native)
Date: Sat, 05 Jan 2019 07:57:00 -0000 [thread overview]
Message-ID: <20190105075735.GF28188@adacore.com> (raw)
In-Reply-To: <bdbd77389265e70e1cacc0cc07dcc399@polymtl.ca>
>>> gdb/ChangeLog:
>>>
>>> * thread.c (delete_thread_1): Add gdb_assert that THR is not
>>> NULL. Initialize tpprev to NULL instead of assigning it
>>> to NULL on the next statement.
>>> * windows-nat.c (windows_delete_thread): Remove check for
>>> main_thread_id before printing thread exit notifications.
>>> (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
>>> Remove thread ID check against main_thread_id.
>>> <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
>>> windows_delete_thread.
>>> <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
> Yes, thanks for the explanation, everything LGTM.
Thank you Simon; I just pushed the patch.
I am also happy to say that I have a patch for the secondary
suggestion of avoiding the thread creation/exit notification
for the main thread. I will let it run through our nightly testing
for a couple of days and send it here for review afterwards.
--
Joel
prev parent reply other threads:[~2019-01-05 7:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-31 3:58 Joel Brobecker
2019-01-02 23:03 ` Simon Marchi
2019-01-03 3:33 ` Joel Brobecker
2019-01-03 3:48 ` Simon Marchi
2019-01-05 7:57 ` Joel Brobecker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190105075735.GF28188@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox