From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 55069 invoked by alias); 5 Jan 2019 07:57:45 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 55060 invoked by uid 89); 5 Jan 2019 07:57:44 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=sk:create_, our X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 05 Jan 2019 07:57:43 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 26D46117568; Sat, 5 Jan 2019 02:57:41 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id wPTYwA4Ir1NT; Sat, 5 Jan 2019 02:57:41 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id B32B8117530; Sat, 5 Jan 2019 02:57:40 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id F0780867B9; Sat, 5 Jan 2019 11:57:35 +0400 (+04) Date: Sat, 05 Jan 2019 07:57:00 -0000 From: Joel Brobecker To: Simon Marchi Cc: gdb-patches@sourceware.org Subject: Re: [RFA/commit] GDB crash re-running program on Windows (native) Message-ID: <20190105075735.GF28188@adacore.com> References: <20181231035750.8063-1-brobecker@adacore.com> <2c42b3197a35871cbc92d564f1772922@polymtl.ca> <20190103033347.GD28188@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-SW-Source: 2019-01/txt/msg00075.txt.bz2 >>> gdb/ChangeLog: >>> >>> * thread.c (delete_thread_1): Add gdb_assert that THR is not >>> NULL. Initialize tpprev to NULL instead of assigning it >>> to NULL on the next statement. >>> * windows-nat.c (windows_delete_thread): Remove check for >>> main_thread_id before printing thread exit notifications. >>> (get_windows_debug_event) : >>> Remove thread ID check against main_thread_id. >>> : Remove call to >>> windows_delete_thread. >>> : Add call to windows_delete_thread. > Yes, thanks for the explanation, everything LGTM. Thank you Simon; I just pushed the patch. I am also happy to say that I have a patch for the secondary suggestion of avoiding the thread creation/exit notification for the main thread. I will let it run through our nightly testing for a couple of days and send it here for review afterwards. -- Joel