From: Joel Brobecker <brobecker@adacore.com>
To: Philippe Waroquiers <philippe.waroquiers@skynet.be>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFAv2 1/4] Fix gdb.ada/packed_array_assign.exp by using more unique names.
Date: Wed, 26 Dec 2018 15:20:00 -0000 [thread overview]
Message-ID: <20181226152036.GC21851@adacore.com> (raw)
In-Reply-To: <20181226140304.19594-2-philippe.waroquiers@skynet.be>
> The test gdb.ada/packed_array_assign fails due to conflict between component 'w'
> and system.dim.mks.w:
>
> (gdb) print pra := ((x => 2, y => 0, w => 17), pr, (x => 7, y => 1, w => 23))
> Unknown component name: system.dim.mks.w.
> (gdb) FAIL: gdb.ada/packed_array_assign.exp: print pra := ((x => 2, y => 0, w => 17), pr, (x => 7, y => 1, w => 23))
>
> Also, depending on the compiler version, the component w might be reordered
> and placed before components x and y.
> So, change the component order in the source, so that both an old
> compiler (GNATMAKE 6.3.0, gcc (Debian 6.3.0-18+deb9u1) 6.3.0 20170516)
> and a new compiler (GNATMAKE Pro 20.0w (20181210-82), based on gcc 8.2.1)
> produce the same component order (checked by using -gnatR3s).
>
> So, update to test the new (more unique) names in the source order.
>
> 2018-12-26 Philippe Waroquiers <philippe.waroquiers@skynet.be>
>
> * gdb.ada/packed_array_assign/aggregates.ads (Packed_Rec):
> Rename components to Packed_Array_Assign_[X|Y|W]. Place
> component Packed_Array_Assign_W as first component, to ensure
> old and new compilers have the same representation.
> All users updated.
Thank you, Philippe. This is OK!
--
Joel
prev parent reply other threads:[~2018-12-26 15:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-26 14:03 [RFAv2 0/4] Fix some gdb.ada tests failure " Philippe Waroquiers
2018-12-26 14:03 ` [RFAv2 4/4] Fix gdb.ada/fun_renaming.exp " Philippe Waroquiers
2018-12-27 2:39 ` Joel Brobecker
2018-12-27 10:07 ` Philippe Waroquiers
2018-12-26 14:03 ` [RFAv2 2/4] Fix gdb.ada/rename_subscript_param.exp " Philippe Waroquiers
2018-12-26 15:27 ` Joel Brobecker
2018-12-26 15:50 ` Philippe Waroquiers
2018-12-27 2:36 ` Joel Brobecker
2018-12-26 14:03 ` [RFAv2 3/4] Fix gdb.ada/assign_arr.exp " Philippe Waroquiers
2018-12-26 15:29 ` Joel Brobecker
2018-12-26 14:03 ` [RFAv2 1/4] Fix gdb.ada/packed_array_assign.exp " Philippe Waroquiers
2018-12-26 15:20 ` Joel Brobecker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181226152036.GC21851@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=philippe.waroquiers@skynet.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox