From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 48671 invoked by alias); 26 Dec 2018 15:20:48 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 48654 invoked by uid 89); 26 Dec 2018 15:20:46 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=ok, HTo:D*be, Hx-languages-length:1276 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 26 Dec 2018 15:20:45 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 71316116441; Wed, 26 Dec 2018 10:20:43 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id wsO-MDXFXSUE; Wed, 26 Dec 2018 10:20:43 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id E889B11642A; Wed, 26 Dec 2018 10:20:42 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id C6DEE86753; Wed, 26 Dec 2018 19:20:36 +0400 (+04) Date: Wed, 26 Dec 2018 15:20:00 -0000 From: Joel Brobecker To: Philippe Waroquiers Cc: gdb-patches@sourceware.org Subject: Re: [RFAv2 1/4] Fix gdb.ada/packed_array_assign.exp by using more unique names. Message-ID: <20181226152036.GC21851@adacore.com> References: <20181226140304.19594-1-philippe.waroquiers@skynet.be> <20181226140304.19594-2-philippe.waroquiers@skynet.be> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181226140304.19594-2-philippe.waroquiers@skynet.be> User-Agent: Mutt/1.9.4 (2018-02-28) X-SW-Source: 2018-12/txt/msg00330.txt.bz2 > The test gdb.ada/packed_array_assign fails due to conflict between component 'w' > and system.dim.mks.w: > > (gdb) print pra := ((x => 2, y => 0, w => 17), pr, (x => 7, y => 1, w => 23)) > Unknown component name: system.dim.mks.w. > (gdb) FAIL: gdb.ada/packed_array_assign.exp: print pra := ((x => 2, y => 0, w => 17), pr, (x => 7, y => 1, w => 23)) > > Also, depending on the compiler version, the component w might be reordered > and placed before components x and y. > So, change the component order in the source, so that both an old > compiler (GNATMAKE 6.3.0, gcc (Debian 6.3.0-18+deb9u1) 6.3.0 20170516) > and a new compiler (GNATMAKE Pro 20.0w (20181210-82), based on gcc 8.2.1) > produce the same component order (checked by using -gnatR3s). > > So, update to test the new (more unique) names in the source order. > > 2018-12-26 Philippe Waroquiers > > * gdb.ada/packed_array_assign/aggregates.ads (Packed_Rec): > Rename components to Packed_Array_Assign_[X|Y|W]. Place > component Packed_Array_Assign_W as first component, to ensure > old and new compilers have the same representation. > All users updated. Thank you, Philippe. This is OK! -- Joel