Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Kevin Buettner <kevinb@redhat.com>
To: gdb-patches@sourceware.org
Cc: Simon Marchi <simon.marchi@ericsson.com>
Subject: Re: [PATCH] Use std::forward_list for displaced_step_inferior_states
Date: Sun, 18 Nov 2018 18:56:00 -0000	[thread overview]
Message-ID: <20181118115650.7731e488@pinnacle.lan> (raw)
In-Reply-To: <20181112185945.24599-1-simon.marchi@ericsson.com>

On Mon, 12 Nov 2018 19:00:03 +0000
Simon Marchi <simon.marchi@ericsson.com> wrote:

> Use std::forward_list instead of manually implemented list.  This
> simplifies a bit the code, especially around removal.
> 
> Regtested on the buildbot.  There are some failures as always, but I
> think they are unrelated.
> 
> gdb/ChangeLog:
> 
> 	* infrun.c (displaced_step_inferior_states): Change type to
> 	std::forward_list.
> 	(get_displaced_stepping_state): Adjust.
> 	(displaced_step_in_progress_any_inferior): Adjust.
> 	(add_displaced_stepping_state): Adjust.
> 	(remove_displaced_stepping_state): Adjust.

LGTM.

Kevin


       reply	other threads:[~2018-11-18 18:56 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20181112185945.24599-1-simon.marchi@ericsson.com>
2018-11-18 18:56 ` Kevin Buettner [this message]
2018-11-19 16:58   ` Simon Marchi
2018-11-19 23:21 ` David Blaikie
2018-11-20  4:03   ` Simon Marchi
2018-11-21 17:27     ` David Blaikie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181118115650.7731e488@pinnacle.lan \
    --to=kevinb@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=simon.marchi@ericsson.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox