From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11419 invoked by alias); 18 Nov 2018 18:56:56 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 11401 invoked by uid 89); 18 Nov 2018 18:56:53 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=sk:displac, unrelated X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 18 Nov 2018 18:56:52 +0000 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A2773369BC; Sun, 18 Nov 2018 18:56:51 +0000 (UTC) Received: from pinnacle.lan (ovpn-116-78.phx2.redhat.com [10.3.116.78]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 722E15D9C9; Sun, 18 Nov 2018 18:56:51 +0000 (UTC) Date: Sun, 18 Nov 2018 18:56:00 -0000 From: Kevin Buettner To: gdb-patches@sourceware.org Cc: Simon Marchi Subject: Re: [PATCH] Use std::forward_list for displaced_step_inferior_states Message-ID: <20181118115650.7731e488@pinnacle.lan> In-Reply-To: <20181112185945.24599-1-simon.marchi@ericsson.com> References: <20181112185945.24599-1-simon.marchi@ericsson.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2018-11/txt/msg00282.txt.bz2 On Mon, 12 Nov 2018 19:00:03 +0000 Simon Marchi wrote: > Use std::forward_list instead of manually implemented list. This > simplifies a bit the code, especially around removal. > > Regtested on the buildbot. There are some failures as always, but I > think they are unrelated. > > gdb/ChangeLog: > > * infrun.c (displaced_step_inferior_states): Change type to > std::forward_list. > (get_displaced_stepping_state): Adjust. > (displaced_step_in_progress_any_inferior): Adjust. > (add_displaced_stepping_state): Adjust. > (remove_displaced_stepping_state): Adjust. LGTM. Kevin