From: Kevin Buettner <kevinb@redhat.com>
To: gdb-patches@sourceware.org
Subject: Re: [PATCH 2/2] GDB: S12Z: new function s12z_extract_return_value
Date: Sun, 18 Nov 2018 18:28:00 -0000 [thread overview]
Message-ID: <20181118112846.297a4ed9@pinnacle.lan> (raw)
In-Reply-To: <20181118091337.tqzu3rhmaeyxw7zp@jocasta.intra>
On Sun, 18 Nov 2018 10:13:37 +0100
John Darrington <john@darrington.wattle.id.au> wrote:
> Hi Kevin,
>
> Thanks for the review.
>
> On Sat, Nov 17, 2018 at 11:35:50PM -0700, Kevin Buettner wrote:
> >
> > gdb/ChangeLog:
> > * s12z-tdep.c (s12z_extract_return_value): New function.
> > (inv_reg_perm) New array.
> > (s12z_return_value): Populate readbuf if non-null.
>
> Make sure that this is indented correctly when it eventually goes
> in the ChangeLog file.
>
> Is it documented anywhere what "correctly" means?
https://www.gnu.org/prep/standards/standards.html#Change-Logs
https://www.gnu.org/software/emacs/manual/html_node/emacs/Format-of-ChangeLog.html
Though with regards to indentation, neither of those links adequately
describe the ChangeLog entries that we've been using for many years
now.
When you do the commit / push, your ChangeLog entry should look something
like this:
YYYY-MM-DD John Darrington <john@darrington.wattle.id.au>
* s12z-tdep.c (s12z_extract_return_value): New function.
(inv_reg_perm) New array.
(s12z_return_value): Populate readbuf if non-null.
In particular, a single tab precedes the non-header (and non-empty)
portions of the ChangeLog entry.
Kevin
next prev parent reply other threads:[~2018-11-18 18:28 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-12 9:18 [PATCH 1/2] GDB: S12Z: Add assertion John Darrington
2018-11-12 9:18 ` [PATCH 2/2] GDB: S12Z: new function s12z_extract_return_value John Darrington
2018-11-18 6:35 ` Kevin Buettner
2018-11-18 9:13 ` John Darrington
2018-11-18 18:28 ` Kevin Buettner [this message]
2018-11-20 7:56 ` [PATCH] " John Darrington
2018-11-20 16:40 ` Kevin Buettner
2018-11-20 17:01 ` John Darrington
2018-11-17 21:59 ` [PATCH 1/2] GDB: S12Z: Add assertion Kevin Buettner
2018-11-18 9:23 ` John Darrington
2018-11-18 18:42 ` Kevin Buettner
2018-11-19 16:09 ` Joel Brobecker
2018-11-19 16:47 ` [PATCH] " John Darrington
2018-11-20 5:16 ` Kevin Buettner
2018-11-15 19:02 [PATCH 2/2] GDB: S12Z: new function s12z_extract_return_value John Darrington
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181118112846.297a4ed9@pinnacle.lan \
--to=kevinb@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox