From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 86066 invoked by alias); 18 Nov 2018 18:28:50 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 85827 invoked by uid 89); 18 Nov 2018 18:28:49 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,KAM_SHORT,SPF_HELO_PASS autolearn=no version=3.3.2 spammy=adequately, H*c:US-ASCII X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 18 Nov 2018 18:28:48 +0000 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 42CA5356CD for ; Sun, 18 Nov 2018 18:28:47 +0000 (UTC) Received: from pinnacle.lan (ovpn-116-78.phx2.redhat.com [10.3.116.78]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2746C60BF1 for ; Sun, 18 Nov 2018 18:28:47 +0000 (UTC) Date: Sun, 18 Nov 2018 18:28:00 -0000 From: Kevin Buettner To: gdb-patches@sourceware.org Subject: Re: [PATCH 2/2] GDB: S12Z: new function s12z_extract_return_value Message-ID: <20181118112846.297a4ed9@pinnacle.lan> In-Reply-To: <20181118091337.tqzu3rhmaeyxw7zp@jocasta.intra> References: <20181112091721.28040-1-john@darrington.wattle.id.au> <20181112091721.28040-2-john@darrington.wattle.id.au> <20181117233550.09353eeb@pinnacle.lan> <20181118091337.tqzu3rhmaeyxw7zp@jocasta.intra> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2018-11/txt/msg00279.txt.bz2 On Sun, 18 Nov 2018 10:13:37 +0100 John Darrington wrote: > Hi Kevin, > > Thanks for the review. > > On Sat, Nov 17, 2018 at 11:35:50PM -0700, Kevin Buettner wrote: > > > > gdb/ChangeLog: > > * s12z-tdep.c (s12z_extract_return_value): New function. > > (inv_reg_perm) New array. > > (s12z_return_value): Populate readbuf if non-null. > > Make sure that this is indented correctly when it eventually goes > in the ChangeLog file. > > Is it documented anywhere what "correctly" means? https://www.gnu.org/prep/standards/standards.html#Change-Logs https://www.gnu.org/software/emacs/manual/html_node/emacs/Format-of-ChangeLog.html Though with regards to indentation, neither of those links adequately describe the ChangeLog entries that we've been using for many years now. When you do the commit / push, your ChangeLog entry should look something like this: YYYY-MM-DD John Darrington * s12z-tdep.c (s12z_extract_return_value): New function. (inv_reg_perm) New array. (s12z_return_value): Populate readbuf if non-null. In particular, a single tab precedes the non-header (and non-empty) portions of the ChangeLog entry. Kevin