From: Joel Brobecker <brobecker@adacore.com>
To: Pedro Alves <palves@redhat.com>
Cc: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: pushed: [RFA] Move copy_bitwise unittests to own unittest file
Date: Thu, 15 Nov 2018 15:56:00 -0000 [thread overview]
Message-ID: <20181115155558.GA2573@adacore.com> (raw)
In-Reply-To: <1be97baa-1a76-dd84-e894-3e00036ec365@redhat.com>
> > gdb/ChangeLog:
> >
> > * unittests/copy_bitwise-selftests.c: New file.
> > * utils.c (selftests::bits_to_str, selftests::check_copy_bitwise)
> > (selftests::copy_bitwise_tests): Delete, moving this code to
> > unittests/copy_bitwise-selftests.c instead.
> > (_initialize_utils): Do not register copy_bitwise tests.
> > * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
> > unittests/copy_bitwise-selftests.c.
> >
> > Tested on x86_64-linux using the official testsuite, but also by
> > verifying that "maintenance selftests" still runs the copy_bitwise
> > tests.
> >
> > OK to push to master?
> >
>
> OK.
Thanks Pedro. Pushed to master. And thanks also to Tom, who pointed
out the issue and even tried to fix it; this started us towards
a nice little cleanup. Really nice :)
--
Joel
prev parent reply other threads:[~2018-11-15 15:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-24 16:21 [PATCH] Fix buffer overflow in ada-lang.c:move_bits Tom Tromey
2018-11-01 15:35 ` Joel Brobecker
2018-11-01 22:16 ` Tom Tromey
2018-11-08 19:11 ` Pedro Alves
2018-11-08 19:12 ` Pedro Alves
2018-11-09 17:16 ` Joel Brobecker
2018-11-14 17:11 ` Joel Brobecker
2018-11-14 17:23 ` Pedro Alves
2018-11-14 23:17 ` Joel Brobecker
2018-11-15 0:02 ` [RFA] Move copy_bitwise unittests to own unittest file (was: "Re: [PATCH] Fix buffer overflow in ada-lang.c:move_bits") Joel Brobecker
2018-11-15 10:59 ` [RFA] Move copy_bitwise unittests to own unittest file Pedro Alves
2018-11-15 15:56 ` Joel Brobecker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181115155558.GA2573@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox