From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 66926 invoked by alias); 15 Nov 2018 15:56:04 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 66915 invoked by uid 89); 15 Nov 2018 15:56:03 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:847 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 15 Nov 2018 15:56:01 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 4EE7556060; Thu, 15 Nov 2018 10:56:00 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id i9EiOOt43Var; Thu, 15 Nov 2018 10:56:00 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 11EA856057; Thu, 15 Nov 2018 10:56:00 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 590E7849EC; Thu, 15 Nov 2018 07:55:58 -0800 (PST) Date: Thu, 15 Nov 2018 15:56:00 -0000 From: Joel Brobecker To: Pedro Alves Cc: Tom Tromey , gdb-patches@sourceware.org Subject: pushed: [RFA] Move copy_bitwise unittests to own unittest file Message-ID: <20181115155558.GA2573@adacore.com> References: <20181024162037.21024-1-tom@tromey.com> <20181101153517.GA2705@adacore.com> <082f66ea-223b-52f4-bc24-b274dbcf4f01@redhat.com> <609409e6-235a-4724-3ced-57c3ff42e299@redhat.com> <20181109171641.GD18647@adacore.com> <20181114171116.GA6074@adacore.com> <7628ab26-ad93-726c-f1d4-d5c60492115c@redhat.com> <20181114231724.GA4336@adacore.com> <20181115000158.GC4336@adacore.com> <1be97baa-1a76-dd84-e894-3e00036ec365@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1be97baa-1a76-dd84-e894-3e00036ec365@redhat.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-SW-Source: 2018-11/txt/msg00239.txt.bz2 > > gdb/ChangeLog: > > > > * unittests/copy_bitwise-selftests.c: New file. > > * utils.c (selftests::bits_to_str, selftests::check_copy_bitwise) > > (selftests::copy_bitwise_tests): Delete, moving this code to > > unittests/copy_bitwise-selftests.c instead. > > (_initialize_utils): Do not register copy_bitwise tests. > > * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add > > unittests/copy_bitwise-selftests.c. > > > > Tested on x86_64-linux using the official testsuite, but also by > > verifying that "maintenance selftests" still runs the copy_bitwise > > tests. > > > > OK to push to master? > > > > OK. Thanks Pedro. Pushed to master. And thanks also to Tom, who pointed out the issue and even tried to fix it; this started us towards a nice little cleanup. Really nice :) -- Joel