Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andrew Burgess <andrew.burgess@embecosm.com>
To: John Baldwin <jhb@FreeBSD.org>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Note that PT_GETREGS supplies SSTATUS for FreeBSD/riscv.
Date: Mon, 05 Nov 2018 22:35:00 -0000	[thread overview]
Message-ID: <20181105223454.GF16539@embecosm.com> (raw)
In-Reply-To: <20181105215723.23683-1-jhb@FreeBSD.org>

* John Baldwin <jhb@FreeBSD.org> [2018-11-05 13:57:23 -0800]:

> This permits reading the value of the SSTATUS CSR returned by ptrace()
> for live FreeBSD/riscv processes.
> 
> 	* riscv-fbsd-nat.c (getregs_supplies): Return true for
> 	RISCV_CSR_SSTATUS_REGNUM.

Looks good.  Thanks,

Andrew

> ---
>  gdb/ChangeLog        | 5 +++++
>  gdb/riscv-fbsd-nat.c | 3 ++-
>  2 files changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/gdb/ChangeLog b/gdb/ChangeLog
> index bc77fe85c7..b78d58625e 100644
> --- a/gdb/ChangeLog
> +++ b/gdb/ChangeLog
> @@ -1,3 +1,8 @@
> +2018-11-05  John Baldwin  <jhb@FreeBSD.org>
> +
> +	* riscv-fbsd-nat.c (getregs_supplies): Return true for
> +	RISCV_CSR_SSTATUS_REGNUM.
> +
>  2018-11-04  Tom Tromey  <tom@tromey.com>
>  
>  	* varobj.c (install_default_visualizer): Update.
> diff --git a/gdb/riscv-fbsd-nat.c b/gdb/riscv-fbsd-nat.c
> index ad4ea1e0ad..e66f491284 100644
> --- a/gdb/riscv-fbsd-nat.c
> +++ b/gdb/riscv-fbsd-nat.c
> @@ -42,7 +42,8 @@ static riscv_fbsd_nat_target the_riscv_fbsd_nat_target;
>  static bool
>  getregs_supplies (struct gdbarch *gdbarch, int regnum)
>  {
> -  return (regnum >= RISCV_RA_REGNUM && regnum <= RISCV_PC_REGNUM);
> +  return ((regnum >= RISCV_RA_REGNUM && regnum <= RISCV_PC_REGNUM)
> +	  || regnum == RISCV_CSR_SSTATUS_REGNUM);
>  }
>  
>  /* Determine if PT_GETFPREGS fetches REGNUM.  */
> -- 
> 2.18.0
> 


      reply	other threads:[~2018-11-05 22:35 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-05 21:57 John Baldwin
2018-11-05 22:35 ` Andrew Burgess [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181105223454.GF16539@embecosm.com \
    --to=andrew.burgess@embecosm.com \
    --cc=gdb-patches@sourceware.org \
    --cc=jhb@FreeBSD.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox