From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 104314 invoked by alias); 5 Nov 2018 22:35:01 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 104283 invoked by uid 89); 5 Nov 2018 22:35:01 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-25.2 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=HX-Received:a5d, H*RU:sk:host81-, Hx-spam-relays-external:sk:host81- X-HELO: mail-wr1-f68.google.com Received: from mail-wr1-f68.google.com (HELO mail-wr1-f68.google.com) (209.85.221.68) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 05 Nov 2018 22:34:59 +0000 Received: by mail-wr1-f68.google.com with SMTP id o15-v6so7680556wrv.4 for ; Mon, 05 Nov 2018 14:34:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=T7NI7olLyB1ORQKujef+59E2u2xlyRIwgktw3GErJhk=; b=I90GCrDGJK7pTAzL0072/Q4/khzjbVf9tbnWoAHJRoC4YL8b5wOSOLZ+JxDTHwTxUj 2RmS+GPgy4qK7xo2g1dTM3xO8/LStfZTgQH2L4W6pkhqVBziVYC7Pua4Xlhqhn2gdCfL 0E5V03HrNGC3QWS0L5pRRJh1Cj4SJN4yyy5Lgg+umw+5LQDa3hFVhIr06e5848JBdn1x E4vRndWjI/KEKs2UlYUeCq2uB8N9eOSu5Cmt2N181QCqXmBKJs/bQM4JxHtbokAc/IqY UDe8QfA5c3uVHkRYOU8BjwkEPD3zkZm24EDs0mPQnHMDGymzXC5BFAghMrAqeMAxZWPd FkVw== Return-Path: Received: from localhost (host81-148-252-35.range81-148.btcentralplus.com. [81.148.252.35]) by smtp.gmail.com with ESMTPSA id k4sm15101350wrx.91.2018.11.05.14.34.56 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 05 Nov 2018 14:34:56 -0800 (PST) Date: Mon, 05 Nov 2018 22:35:00 -0000 From: Andrew Burgess To: John Baldwin Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Note that PT_GETREGS supplies SSTATUS for FreeBSD/riscv. Message-ID: <20181105223454.GF16539@embecosm.com> References: <20181105215723.23683-1-jhb@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181105215723.23683-1-jhb@FreeBSD.org> X-Fortune: This is the tomorrow you worried about yesterday. And now you know why. X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] User-Agent: Mutt/1.9.2 (2017-12-15) X-IsSubscribed: yes X-SW-Source: 2018-11/txt/msg00050.txt.bz2 * John Baldwin [2018-11-05 13:57:23 -0800]: > This permits reading the value of the SSTATUS CSR returned by ptrace() > for live FreeBSD/riscv processes. > > * riscv-fbsd-nat.c (getregs_supplies): Return true for > RISCV_CSR_SSTATUS_REGNUM. Looks good. Thanks, Andrew > --- > gdb/ChangeLog | 5 +++++ > gdb/riscv-fbsd-nat.c | 3 ++- > 2 files changed, 7 insertions(+), 1 deletion(-) > > diff --git a/gdb/ChangeLog b/gdb/ChangeLog > index bc77fe85c7..b78d58625e 100644 > --- a/gdb/ChangeLog > +++ b/gdb/ChangeLog > @@ -1,3 +1,8 @@ > +2018-11-05 John Baldwin > + > + * riscv-fbsd-nat.c (getregs_supplies): Return true for > + RISCV_CSR_SSTATUS_REGNUM. > + > 2018-11-04 Tom Tromey > > * varobj.c (install_default_visualizer): Update. > diff --git a/gdb/riscv-fbsd-nat.c b/gdb/riscv-fbsd-nat.c > index ad4ea1e0ad..e66f491284 100644 > --- a/gdb/riscv-fbsd-nat.c > +++ b/gdb/riscv-fbsd-nat.c > @@ -42,7 +42,8 @@ static riscv_fbsd_nat_target the_riscv_fbsd_nat_target; > static bool > getregs_supplies (struct gdbarch *gdbarch, int regnum) > { > - return (regnum >= RISCV_RA_REGNUM && regnum <= RISCV_PC_REGNUM); > + return ((regnum >= RISCV_RA_REGNUM && regnum <= RISCV_PC_REGNUM) > + || regnum == RISCV_CSR_SSTATUS_REGNUM); > } > > /* Determine if PT_GETFPREGS fetches REGNUM. */ > -- > 2.18.0 >