From: Joel Brobecker <brobecker@adacore.com>
To: Andrew Burgess <andrew.burgess@embecosm.com>
Cc: gdb-patches@sourceware.org, jimw@sifive.com, palmer@sifive.com
Subject: Re: [PATCH] gdb/riscv: Improve non-dwarf stack unwinding
Date: Wed, 26 Sep 2018 16:53:00 -0000 [thread overview]
Message-ID: <20180926165333.GA11310@adacore.com> (raw)
In-Reply-To: <20180926151112.GL5952@embecosm.com>
> > Are you sure you want to assert on the register number? What if
> > the instruction was malformed and the register number ended up
> > being larger than RISCV_NUM_INTEGER_REGS; is that possible?
>
> Well, it shouldn't happen in the sense that, for a given instruction,
> if it operates on integer registers then the space in the encoding
> should only allow for up to RISCV_NUM_INTEGER_REGS registers (some
> encodings allow for less registers).
>
> Right now I can't imagine a situation where one of those asserts could
> fire and it's not either a bug in GDB, or a bug in the libopcode field
> extraction code - hence an assert rather than an error.
OK, that's perfect. Thanks for the confirmation!
--
Joel
next prev parent reply other threads:[~2018-09-26 16:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-19 16:41 Andrew Burgess
2018-09-21 16:20 ` Palmer Dabbelt
2018-09-26 13:13 ` PING: " Andrew Burgess
2018-09-26 13:49 ` Joel Brobecker
2018-09-26 15:11 ` Andrew Burgess
2018-09-26 16:53 ` Joel Brobecker [this message]
2018-09-26 17:13 ` Palmer Dabbelt
2018-09-26 19:15 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180926165333.GA11310@adacore.com \
--to=brobecker@adacore.com \
--cc=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
--cc=jimw@sifive.com \
--cc=palmer@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox