From: Joel Brobecker <brobecker@adacore.com>
To: Simon Marchi <simon.marchi@polymtl.ca>
Cc: Pedro Alves <palves@redhat.com>,
Simon Marchi <simon.marchi@ericsson.com>,
gdb-patches@sourceware.org
Subject: Re: [PATCH] Restore behavior of disabling address randomization by default on GDBserver
Date: Sun, 26 Aug 2018 09:51:00 -0000 [thread overview]
Message-ID: <20180826095056.GA8675@adacore.com> (raw)
In-Reply-To: <ab847bd7be49294a29d0a0b418420cf8@polymtl.ca>
Hello,
> > Thanks for fixing this!
> >
> > This is OK, but please double-check the patch/commit, since it
> > seems to include the same hunk twice. Kind of looks like
> > the fix diff made it to the commit log?
>
> Oops yes, it's because I use "git commit -v" and managed to include that
> diff in the commit message by mistake.
>
> Pushed with that fixed.
Just a quick message to let you know that I cherry-picked the patch and
pushed it to gdb-8.2-branch. I think we wanted this to be fixed there,
right? And the patch looked sufficiently obvious to me that I went
ahead.
2018-08-26 Simon Marchi <simon.marchi@ericsson.com>
PR gdb/23374
PR gdb/23375
* server.h (struct client_state) <disable_randomization>:
Initialize to 1.
--
Joel
next prev parent reply other threads:[~2018-08-26 9:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-22 16:06 Simon Marchi
2018-08-22 16:14 ` Pedro Alves
2018-08-22 17:38 ` Simon Marchi
2018-08-26 9:51 ` Joel Brobecker [this message]
2018-08-26 15:01 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180826095056.GA8675@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
--cc=simon.marchi@ericsson.com \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox