From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 91365 invoked by alias); 26 Aug 2018 09:51:01 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 91350 invoked by uid 89); 26 Aug 2018 09:51:00 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 26 Aug 2018 09:50:59 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 7B0A51162DC; Sun, 26 Aug 2018 05:50:58 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 4Nn161+vBx2e; Sun, 26 Aug 2018 05:50:58 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 4724A1162C8; Sun, 26 Aug 2018 05:50:58 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 5BBA186A7C; Sun, 26 Aug 2018 11:50:56 +0200 (CEST) Date: Sun, 26 Aug 2018 09:51:00 -0000 From: Joel Brobecker To: Simon Marchi Cc: Pedro Alves , Simon Marchi , gdb-patches@sourceware.org Subject: Re: [PATCH] Restore behavior of disabling address randomization by default on GDBserver Message-ID: <20180826095056.GA8675@adacore.com> References: <1534953958-13064-1-git-send-email-simon.marchi@ericsson.com> <1ad11ede-9a61-5ead-921a-bf2c1c1a6358@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-SW-Source: 2018-08/txt/msg00622.txt.bz2 Hello, > > Thanks for fixing this! > > > > This is OK, but please double-check the patch/commit, since it > > seems to include the same hunk twice. Kind of looks like > > the fix diff made it to the commit log? > > Oops yes, it's because I use "git commit -v" and managed to include that > diff in the commit message by mistake. > > Pushed with that fixed. Just a quick message to let you know that I cherry-picked the patch and pushed it to gdb-8.2-branch. I think we wanted this to be fixed there, right? And the patch looked sufficiently obvious to me that I went ahead. 2018-08-26 Simon Marchi PR gdb/23374 PR gdb/23375 * server.h (struct client_state) : Initialize to 1. -- Joel