From: "Ulrich Weigand" <uweigand@de.ibm.com>
To: pedromfc@linux.ibm.com (Pedro Franco de Carvalho)
Cc: gdb-patches@sourceware.org, edjunior@gmail.com
Subject: Re: [PATCH 05/17] [PowerPC] Add support for PPR and DSCR
Date: Fri, 13 Jul 2018 15:23:00 -0000 [thread overview]
Message-ID: <20180713152340.99B47D80276@oc3748833570.ibm.com> (raw)
In-Reply-To: <20180713135226.2321-6-pedromfc@linux.ibm.com> from "Pedro Franco de Carvalho" at Jul 13, 2018 10:52:14 AM
Pedro Franco de Carvalho wrote:
> The gdbserver implementation comes in the next patch. However, because
> powerpc target description declarations are common to gdb and
> gdbserver, the .dat files and gdbserver/configure.srv are altered
> here, in order to avoid breaking the build at the commit corresponding
> to this patch.
I guess it would make sense to combine those (together with the tests
and the record/replay support) into a single commit then.
> gdb/ChangeLog:
> YYYY-MM-DD Edjunior Barbosa Machado <emachado@linux.vnet.ibm.com>
> Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
>
> * arch/ppc-linux-tdesc.h (tdesc_powerpc_isa205_ppr_dscr_vsx32l)
> (tdesc_powerpc_isa205_ppr_dscr_vsx64l): Declare.
> * arch/ppc-linux-common.h (PPC_LINUX_SIZEOF_PPRREGSET)
> (PPC_LINUX_SIZEOF_DSCRREGSET): Define.
> (struct ppc_linux_features) <ppr_dscr>: New field.
> (ppc_linux_no_features): Add initializer for ppr_dscr field.
> * arch/ppc-linux-common.c (ppc_linux_match_description): Return
> new tdescs.
> * nat/ppc-linux.h (PPC_FEATURE2_DSCR, NT_PPC_PPR, NT_PPC_DSCR):
> Define if not already defined.
> * features/Makefile (WHICH): Add
> rs6000/powerpc-isa205-ppr-dscr-vsx32l and
> rs6000/powerpc-isa205-ppr-dscr-vsx64l.
> (XMLTOC): Add rs6000/powerpc-isa205-ppr-dscr-vsx32l.xml and
> rs6000/powerpc-isa205-ppr-dscr-vsx64l.xml.
> * features/rs6000/power-dscr.xml: New file.
> * features/rs6000/power-ppr.xml: New file.
> * features/rs6000/powerpc-isa205-ppr-dscr-vsx32l.xml: New file.
> * features/rs6000/powerpc-isa205-ppr-dscr-vsx64l.xml: New file.
> * features/rs6000/powerpc-isa205-ppr-dscr-vsx32l.c: Generate.
> * features/rs6000/powerpc-isa205-ppr-dscr-vsx64l.c: Generate.
> * regformats/rs6000/powerpc-isa205-ppr-dscr-vsx32l.dat: Generate.
> * regformats/rs6000/powerpc-isa205-ppr-dscr-vsx64l.dat: Generate.
> * ppc-linux-nat.c: Include <sys/uio.h>.
> (fetch_regset, store_regset, check_regset): New functions.
> (fetch_register, fetch_ppc_registers): Call fetch_regset with DSCR
> and PPR regsets.
> (store_register, store_ppc_registers): Call store_regset with DSCR
> and PPR regsets..
> (ppc_linux_get_hwcap2): New function.
> (ppc_linux_nat_target::read_description): Call
> ppc_linux_get_hwcap2 and check_regset, set ppr_dscr field in the
> features struct if needed.
> * ppc-linux-tdep.c: Include
> features/rs6000/powerpc-isa205-ppr-dscr-vsx32l.c and
> features/rs6000/powerpc-isa205-ppr-dscr-vsx64l.c.
> (ppc32_regmap_ppr, ppc32_regmap_dscr, ppc32_linux_pprregset)
> (ppc32_linux_dscrregset): New globals.
> (ppc_linux_iterate_over_regset_sections): Call back with the ppr
> and dscr regsets.
> (ppc_linux_core_read_description): Check if the ppr and dscr
> sections are present and set ppr_dscr in the features struct.
> (_initialize_ppc_linux_tdep): Call
> initialize_tdesc_powerpc_isa205_ppr_dscr_vsx32l and
> initialize_tdesc_powerpc_isa205_ppr_dscr_vsx64l.
> * ppc-linux-tdep.h (ppc32_linux_pprregset)
> (ppc32_linux_dscrregset): Declare.
> * ppc-tdep.h (struct gdbarch_tdep) <ppc_ppr_regnum>: New field.
> <ppc_dscr_regnum>: New field.
> (enum) <PPC_PPR_REGNUM, PPC_DSCR_REGNUM>: New enum values.
> * rs6000-tdep.c (rs6000_gdbarch_init): Look for and validate ppr
> and dscr features.
>
> gdb/gdbserver/ChangeLog:
> YYYY-MM-DD Edjunior Barbosa Machado <emachado@linux.vnet.ibm.com>
> Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
>
> * configure.srv (ipa_ppc_linux_regobj): Add
> powerpc-isa205-ppr-dscr-vsx32l-ipa.o and
> powerpc-isa205-ppr-dscr-vsx64l-ipa.o.
> (powerpc*-*-linux*): Add powerpc-isa205-ppr-dscr-vsx32l.o and
> powerpc-isa205-ppr-dscr-vsx64l.o to srv_regobj, add
> rs6000/power-dscr.xml, rs6000/power-ppr.xml,
> rs6000/powerpc-isa205-ppr-dscr-vsx32l.xml and
> rs6000/powerpc-isa205-ppr-dscr-vsx64l.xml to srv_xmlfiles.
This is OK.
Thanks,
Ulrich
--
Dr. Ulrich Weigand
GNU/Linux compilers and toolchain
Ulrich.Weigand@de.ibm.com
next prev parent reply other threads:[~2018-07-13 15:23 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-13 13:53 [PATCH 00/17] GDB support for more powerpc registers on linux Pedro Franco de Carvalho
2018-07-13 13:53 ` [PATCH 13/17] [PowerPC] Add support for HTM registers Pedro Franco de Carvalho
2018-07-13 16:24 ` Ulrich Weigand
2018-07-13 18:16 ` Pedro Franco de Carvalho
2018-07-13 13:53 ` [PATCH 03/17] [PowerPC] Fix indentation in arch/ppc-linux-common.c Pedro Franco de Carvalho
2018-07-13 15:18 ` Ulrich Weigand
2018-07-13 13:53 ` [PATCH 12/17] [PowerPC] Add tests for TAR Pedro Franco de Carvalho
2018-07-13 15:33 ` Ulrich Weigand
2018-07-13 13:53 ` [PATCH 08/17] [PowerPC] Add tests for PPR and DSCR Pedro Franco de Carvalho
2018-07-13 15:27 ` Ulrich Weigand
2018-07-13 13:53 ` [PATCH 10/17] [PowerPC] Add record/replay support for TAR Pedro Franco de Carvalho
2018-07-13 15:31 ` Ulrich Weigand
2018-07-13 13:53 ` [PATCH 09/17] [PowerPC] Add " Pedro Franco de Carvalho
2018-07-13 15:30 ` Ulrich Weigand
2018-07-13 13:53 ` [PATCH 01/17] [PowerPC] Simplify rs6000_pseudo_register_reggroup_p Pedro Franco de Carvalho
2018-07-13 15:17 ` Ulrich Weigand
2018-07-13 13:53 ` [PATCH 14/17] [PowerPC] Add gdbserver support for HTM registers Pedro Franco de Carvalho
2018-07-13 16:26 ` Ulrich Weigand
2018-07-13 13:53 ` [PATCH 02/17] [PowerPC] Fix two if statements in gdb/ppc-linux-nat.c Pedro Franco de Carvalho
2018-07-13 15:17 ` Ulrich Weigand
2018-07-13 13:53 ` [PATCH 07/17] [PowerPC] Add gdbserver support for PPR and DSCR Pedro Franco de Carvalho
2018-07-13 15:26 ` Ulrich Weigand
2018-07-13 13:53 ` [PATCH 05/17] [PowerPC] Add " Pedro Franco de Carvalho
2018-07-13 15:23 ` Ulrich Weigand [this message]
2018-07-13 13:53 ` [PATCH 16/17] [PowerPC] Add support for EBB and PMU registers Pedro Franco de Carvalho
2018-07-13 16:38 ` Ulrich Weigand
2018-07-13 18:23 ` Pedro Franco de Carvalho
2018-07-13 13:53 ` [PATCH 06/17] [PowerPC] Add record/replay support for PPR and DSCR Pedro Franco de Carvalho
2018-07-13 15:25 ` Ulrich Weigand
2018-07-13 13:53 ` [PATCH 04/17] [PowerPC] Refactor have_ initializers in rs6000-tdep.c Pedro Franco de Carvalho
2018-07-13 15:19 ` Ulrich Weigand
2018-07-13 14:23 ` [PATCH 15/17] [PowerPC] Add tests for HTM registers Pedro Franco de Carvalho
2018-07-13 16:27 ` Ulrich Weigand
2018-07-13 14:49 ` [PATCH 17/17] [PowerPC] Add gdbserver support for EBB and PMU registers Pedro Franco de Carvalho
2018-07-13 16:40 ` Ulrich Weigand
2018-07-13 18:29 ` Pedro Franco de Carvalho
2018-07-13 15:33 ` [PATCH 11/17] [PowerPC] Add gdbserver support for TAR Pedro Franco de Carvalho
2018-07-13 15:33 ` Ulrich Weigand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180713152340.99B47D80276@oc3748833570.ibm.com \
--to=uweigand@de.ibm.com \
--cc=edjunior@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=pedromfc@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox