From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31121 invoked by alias); 13 Jul 2018 15:23:50 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 30558 invoked by uid 89); 13 Jul 2018 15:23:50 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx0a-001b2d01.pphosted.com Received: from mx0b-001b2d01.pphosted.com (HELO mx0a-001b2d01.pphosted.com) (148.163.158.5) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 13 Jul 2018 15:23:48 +0000 Received: from pps.filterd (m0098417.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w6DFKGau039050 for ; Fri, 13 Jul 2018 11:23:47 -0400 Received: from e06smtp02.uk.ibm.com (e06smtp02.uk.ibm.com [195.75.94.98]) by mx0a-001b2d01.pphosted.com with ESMTP id 2k6v58q5e3-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 13 Jul 2018 11:23:46 -0400 Received: from localhost by e06smtp02.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 13 Jul 2018 16:23:45 +0100 Received: from b06cxnps3074.portsmouth.uk.ibm.com (9.149.109.194) by e06smtp02.uk.ibm.com (192.168.101.132) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Fri, 13 Jul 2018 16:23:42 +0100 Received: from d06av25.portsmouth.uk.ibm.com (d06av25.portsmouth.uk.ibm.com [9.149.105.61]) by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w6DFNfHr45613142 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 13 Jul 2018 15:23:41 GMT Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 0227611C054; Fri, 13 Jul 2018 18:24:02 +0100 (BST) Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id D89D111C04A; Fri, 13 Jul 2018 18:24:01 +0100 (BST) Received: from oc3748833570.ibm.com (unknown [9.167.239.119]) by d06av25.portsmouth.uk.ibm.com (Postfix) with ESMTP; Fri, 13 Jul 2018 18:24:01 +0100 (BST) Received: by oc3748833570.ibm.com (Postfix, from userid 1000) id 99B47D80276; Fri, 13 Jul 2018 17:23:40 +0200 (CEST) Subject: Re: [PATCH 05/17] [PowerPC] Add support for PPR and DSCR To: pedromfc@linux.ibm.com (Pedro Franco de Carvalho) Date: Fri, 13 Jul 2018 15:23:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org, edjunior@gmail.com In-Reply-To: <20180713135226.2321-6-pedromfc@linux.ibm.com> from "Pedro Franco de Carvalho" at Jul 13, 2018 10:52:14 AM MIME-Version: 1.0 x-cbid: 18071315-0008-0000-0000-00000252D2BF X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18071315-0009-0000-0000-000021B91210 Message-Id: <20180713152340.99B47D80276@oc3748833570.ibm.com> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit X-SW-Source: 2018-07/txt/msg00407.txt.bz2 Pedro Franco de Carvalho wrote: > The gdbserver implementation comes in the next patch. However, because > powerpc target description declarations are common to gdb and > gdbserver, the .dat files and gdbserver/configure.srv are altered > here, in order to avoid breaking the build at the commit corresponding > to this patch. I guess it would make sense to combine those (together with the tests and the record/replay support) into a single commit then. > gdb/ChangeLog: > YYYY-MM-DD Edjunior Barbosa Machado > Pedro Franco de Carvalho > > * arch/ppc-linux-tdesc.h (tdesc_powerpc_isa205_ppr_dscr_vsx32l) > (tdesc_powerpc_isa205_ppr_dscr_vsx64l): Declare. > * arch/ppc-linux-common.h (PPC_LINUX_SIZEOF_PPRREGSET) > (PPC_LINUX_SIZEOF_DSCRREGSET): Define. > (struct ppc_linux_features) : New field. > (ppc_linux_no_features): Add initializer for ppr_dscr field. > * arch/ppc-linux-common.c (ppc_linux_match_description): Return > new tdescs. > * nat/ppc-linux.h (PPC_FEATURE2_DSCR, NT_PPC_PPR, NT_PPC_DSCR): > Define if not already defined. > * features/Makefile (WHICH): Add > rs6000/powerpc-isa205-ppr-dscr-vsx32l and > rs6000/powerpc-isa205-ppr-dscr-vsx64l. > (XMLTOC): Add rs6000/powerpc-isa205-ppr-dscr-vsx32l.xml and > rs6000/powerpc-isa205-ppr-dscr-vsx64l.xml. > * features/rs6000/power-dscr.xml: New file. > * features/rs6000/power-ppr.xml: New file. > * features/rs6000/powerpc-isa205-ppr-dscr-vsx32l.xml: New file. > * features/rs6000/powerpc-isa205-ppr-dscr-vsx64l.xml: New file. > * features/rs6000/powerpc-isa205-ppr-dscr-vsx32l.c: Generate. > * features/rs6000/powerpc-isa205-ppr-dscr-vsx64l.c: Generate. > * regformats/rs6000/powerpc-isa205-ppr-dscr-vsx32l.dat: Generate. > * regformats/rs6000/powerpc-isa205-ppr-dscr-vsx64l.dat: Generate. > * ppc-linux-nat.c: Include . > (fetch_regset, store_regset, check_regset): New functions. > (fetch_register, fetch_ppc_registers): Call fetch_regset with DSCR > and PPR regsets. > (store_register, store_ppc_registers): Call store_regset with DSCR > and PPR regsets.. > (ppc_linux_get_hwcap2): New function. > (ppc_linux_nat_target::read_description): Call > ppc_linux_get_hwcap2 and check_regset, set ppr_dscr field in the > features struct if needed. > * ppc-linux-tdep.c: Include > features/rs6000/powerpc-isa205-ppr-dscr-vsx32l.c and > features/rs6000/powerpc-isa205-ppr-dscr-vsx64l.c. > (ppc32_regmap_ppr, ppc32_regmap_dscr, ppc32_linux_pprregset) > (ppc32_linux_dscrregset): New globals. > (ppc_linux_iterate_over_regset_sections): Call back with the ppr > and dscr regsets. > (ppc_linux_core_read_description): Check if the ppr and dscr > sections are present and set ppr_dscr in the features struct. > (_initialize_ppc_linux_tdep): Call > initialize_tdesc_powerpc_isa205_ppr_dscr_vsx32l and > initialize_tdesc_powerpc_isa205_ppr_dscr_vsx64l. > * ppc-linux-tdep.h (ppc32_linux_pprregset) > (ppc32_linux_dscrregset): Declare. > * ppc-tdep.h (struct gdbarch_tdep) : New field. > : New field. > (enum) : New enum values. > * rs6000-tdep.c (rs6000_gdbarch_init): Look for and validate ppr > and dscr features. > > gdb/gdbserver/ChangeLog: > YYYY-MM-DD Edjunior Barbosa Machado > Pedro Franco de Carvalho > > * configure.srv (ipa_ppc_linux_regobj): Add > powerpc-isa205-ppr-dscr-vsx32l-ipa.o and > powerpc-isa205-ppr-dscr-vsx64l-ipa.o. > (powerpc*-*-linux*): Add powerpc-isa205-ppr-dscr-vsx32l.o and > powerpc-isa205-ppr-dscr-vsx64l.o to srv_regobj, add > rs6000/power-dscr.xml, rs6000/power-ppr.xml, > rs6000/powerpc-isa205-ppr-dscr-vsx32l.xml and > rs6000/powerpc-isa205-ppr-dscr-vsx64l.xml to srv_xmlfiles. This is OK. Thanks, Ulrich -- Dr. Ulrich Weigand GNU/Linux compilers and toolchain Ulrich.Weigand@de.ibm.com