From: Joel Brobecker <brobecker@adacore.com>
To: Tom de Vries <tdevries@suse.de>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH][gdb/testsuite/ada] Fix number-of-bp test in bp_inlined_func.exp
Date: Mon, 18 Jun 2018 15:31:00 -0000 [thread overview]
Message-ID: <20180618153121.GA2886@adacore.com> (raw)
In-Reply-To: <68c97f70-34bc-1c6c-6241-ff98282173f3@suse.de>
> > - Can you also include the platform itself on which you did the
> > testing?
> >
>
> Done.
>
> > - One spelling issue -- see below.
> >
>
> Fixed.
>
> Thanks for the review.
You are welcome.
In scanning quickly the commit, I noticed you said "x86_64" as
the platform. No need to change anything now, but for your next
submissions, it's better to include the OS as well. Typically,
you'll see people say "tested on x86_64-linux" or "x86-windows",
or "ppc-elf". Many times, the OS doesn't matter, but it's always
good to have it, because the behavior does often depend on the OS.
Thanks for the patch, though. GDB is the better for it, and this is
what _really_ matters ;-).
--
Joel
prev parent reply other threads:[~2018-06-18 15:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-17 15:55 Tom de Vries
2018-06-18 0:12 ` Joel Brobecker
2018-06-18 7:37 ` Tom de Vries
2018-06-18 15:31 ` Joel Brobecker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180618153121.GA2886@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox