From: Tom de Vries <tdevries@suse.de>
To: gdb-patches@sourceware.org
Cc: Joel Brobecker <brobecker@gnat.com>
Subject: [PATCH][gdb/testsuite/ada] Fix number-of-bp test in bp_inlined_func.exp
Date: Sun, 17 Jun 2018 15:55:00 -0000 [thread overview]
Message-ID: <20180617155221.kqev7e3bwxb5uxmq@localhost.localdomain> (raw)
Hi,
Atm bp_inlined_func.exp passes for a combined current gcc and gdb-binutils
repos build but fails for a build with system gcc (7.3.1) and ld (2.29.1).
It checks for 4 breakpoints on read_small:
...
gdb_test "break read_small" \
"Breakpoint $decimal at $hex: read_small\\. \\(4 locations\\)" \
"set breakpoint at read_small"
...
and fails because it gets 5 breakpoint locations instead:
...
(gdb) break read_small
Breakpoint 2 at 0x401f9a: read_small. (5 locations)
(gdb) FAIL: gdb.ada/bp_inlined_func.exp: set breakpoint at read_small
...
The 4 expected breakpoint locations are inlined versions of read_small, and
the 5th breakpoint location has this address:
...
(gdb) info breakpoint
Num Type Disp Enb Address What
1 breakpoint keep y <MULTIPLE>
1.1 y 0x0000000000401f9a in b.read_small
at bp_inlined_func/b.adb:20
...
which is the read_small function itself:
...
(gdb) x 0x0000000000401f9a
0x401f9a <b__read_small+4>: 0x22f8058b
...
This patch updates the test to allow 5 breakpoint locations.
Tested on the configurations mentioned above.
OK for trunk?
Thanks,
- Tom
[gdb/testsuite/ada] Fix number-of-bp test in bp_inlined_func.exp
2018-06-17 Tom de Vries <tdevries@suse.de>
* gdb.ada/bp_inlined_func.exp: Allow 5 breakpoint locations.
---
gdb/testsuite/gdb.ada/bp_inlined_func.exp | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/gdb/testsuite/gdb.ada/bp_inlined_func.exp b/gdb/testsuite/gdb.ada/bp_inlined_func.exp
index 0f615f5d9b..79f9697124 100644
--- a/gdb/testsuite/gdb.ada/bp_inlined_func.exp
+++ b/gdb/testsuite/gdb.ada/bp_inlined_func.exp
@@ -29,10 +29,10 @@ if ![runto_main] then {
}
# Check that inserting breakpoint on read_small inlined function inserts
-# 4 breakpoints.
+# 4 breakpoints (or posibbly 5, including the read_small function itself).
gdb_test "break read_small" \
- "Breakpoint $decimal at $hex: read_small\\. \\(4 locations\\)" \
+ "Breakpoint $decimal at $hex: read_small\\. \\(\[45\] locations\\)" \
"set breakpoint at read_small"
# We do not verify each breakpoint info, but use continue commands instead
next reply other threads:[~2018-06-17 15:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-17 15:55 Tom de Vries [this message]
2018-06-18 0:12 ` Joel Brobecker
2018-06-18 7:37 ` Tom de Vries
2018-06-18 15:31 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180617155221.kqev7e3bwxb5uxmq@localhost.localdomain \
--to=tdevries@suse.de \
--cc=brobecker@gnat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox