Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: possible fix for PR symtab/23010
Date: Mon, 14 May 2018 19:43:00 -0000	[thread overview]
Message-ID: <20180514173839.of36lwr4tqwftxtu@adacore.com> (raw)
In-Reply-To: <20180507171309.f4yjprji4g3deubw@adacore.com>

Hi Tom,

On Mon, May 07, 2018 at 10:13:09AM -0700, Joel Brobecker wrote:
> Hello Global Maintainers,
> 
> I was wondering if anyone had any thoughts regarding Tom patch.
> https://sourceware.org/ml/gdb-patches/2018-04/msg00234.html
> 
> Below are my comments on it, and also my interrogations on whether
> we might want this patch in 8.1.1 or not.
> 
> Additional thoughts:
>   - This is a regression
>   - This is an internal error, so it can be fairly problematic
>   - It only happens with -readnow, it seems, which I assume
>     is not widely used considering the performance and memory
>     cost of this feature.
> 
> I might tip in favor of putting it in, considering the fact that
> I don't think there is much of a workaround, but I would not make
> that call just on my own, because the patch is far from obvious.

Considering that the patch has been under review for 1 month, and
has been available for additional comments for a couple of weeks
since my review, and that this patch is a potential for inclusion
in 8.1.1, I propose we rebase, make whatever tiny adjustments that
were discussed, and start by pushing it to master.

As mentioned in my weekly update of the 8.1.1 release, we can then
wait a week or two before deciding whether we want it in 8.1.1 or not.

WDYT?

Thanks!
-- 
Joel


  reply	other threads:[~2018-05-14 17:38 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-12 19:06 Tom Tromey
2018-04-17 19:17 ` Keith Seitz
2018-04-19 20:39   ` Tom Tromey
2018-04-30 22:44   ` Joel Brobecker
2018-05-07 17:13     ` Joel Brobecker
2018-05-14 19:43       ` Joel Brobecker [this message]
2018-05-18  1:22       ` Sergio Durigan Junior
2018-05-24  4:08         ` Tom Tromey
2018-05-24 10:50           ` Sergio Durigan Junior
2018-05-24 10:50             ` Tom Tromey
2018-05-24 15:54               ` Keith Seitz
2018-05-26  0:24                 ` Keith Seitz
2018-05-27 15:20                   ` Tom Tromey
2018-05-30 22:26                   ` Joel Brobecker
2018-05-17 17:16   ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180514173839.of36lwr4tqwftxtu@adacore.com \
    --to=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox