From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12144 invoked by alias); 14 May 2018 17:38:44 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 12134 invoked by uid 89); 14 May 2018 17:38:43 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=no version=3.3.2 spammy=Below, weekly, adjustments, month X-HELO: rock.gnat.com Received: from Unknown (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 14 May 2018 17:38:42 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 1784C117BC9; Mon, 14 May 2018 13:38:41 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id kuyRJhEAr3jb; Mon, 14 May 2018 13:38:41 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id DB0341172FA; Mon, 14 May 2018 13:38:40 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 3DE2E809B5; Mon, 14 May 2018 10:38:39 -0700 (PDT) Date: Mon, 14 May 2018 19:43:00 -0000 From: Joel Brobecker To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: possible fix for PR symtab/23010 Message-ID: <20180514173839.of36lwr4tqwftxtu@adacore.com> References: <87po34kzxh.fsf@tromey.com> <20180430224454.wrnu4u45o5gukrxs@adacore.com> <20180507171309.f4yjprji4g3deubw@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180507171309.f4yjprji4g3deubw@adacore.com> User-Agent: NeoMutt/20170113 (1.7.2) X-SW-Source: 2018-05/txt/msg00322.txt.bz2 Hi Tom, On Mon, May 07, 2018 at 10:13:09AM -0700, Joel Brobecker wrote: > Hello Global Maintainers, > > I was wondering if anyone had any thoughts regarding Tom patch. > https://sourceware.org/ml/gdb-patches/2018-04/msg00234.html > > Below are my comments on it, and also my interrogations on whether > we might want this patch in 8.1.1 or not. > > Additional thoughts: > - This is a regression > - This is an internal error, so it can be fairly problematic > - It only happens with -readnow, it seems, which I assume > is not widely used considering the performance and memory > cost of this feature. > > I might tip in favor of putting it in, considering the fact that > I don't think there is much of a workaround, but I would not make > that call just on my own, because the patch is far from obvious. Considering that the patch has been under review for 1 month, and has been available for additional comments for a couple of weeks since my review, and that this patch is a potential for inclusion in 8.1.1, I propose we rebase, make whatever tiny adjustments that were discussed, and start by pushing it to master. As mentioned in my weekly update of the 8.1.1 release, we can then wait a week or two before deciding whether we want it in 8.1.1 or not. WDYT? Thanks! -- Joel